Skip to content

Resolve "ROI movable even though fix is checked"

d.kilic requested to merge 529-roi-movable-even-though-fix-is-checked into master

Error happened due to Control and the RoiItem having different default values and Control not overwriting the value from RoiItem at init, only after change in UI.

Two commits:

  1. Reproduction of error inside of a unit test
  2. Fixing of error by setting the fixed value of RoiItem in the constructor of Control

Reviewer Checklist

General code quality

  • naming conventions are met (see .clang-tidy for detailed information)
  • no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)

General usability

  • old versions of pet-files are still loadable
  • documentation updated (if applicable)

Only if changes in UI

  • new elements are also saved and loaded from pet-file
  • check if tab order is still correct
  • all new SpinBoxes are promoted
  • new keybindings added to Petrack::keyBindings()

Closes #529

Merge request reports

Loading