Skip to content
Snippets Groups Projects

make Animation member of petrack

Merged Tobias Arens requested to merge 519-refactor-animation-to-be-a-member-of-petrack into master

Change mAnimation in petrack to not be a pointer anymore, but an instance of Animation.

Reviewer Checklist

General code quality

  • naming conventions are met (see .clang-tidy for detailed information)
  • no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)

General usability

  • old versions of pet-files are still loadable
  • documentation updated (if applicable)

Only if changes in UI

  • new elements are also saved and loaded from pet-file
  • check if tab order is still correct
  • all new SpinBoxes are promoted
  • new keybindings added to Petrack::keyBindings()

Closes #519 (closed)

Edited by d.kilic

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • d.kilic marked the checklist item naming conventions are met (see .clang-tidy for detailed information) as completed

    marked the checklist item naming conventions are met (see .clang-tidy for detailed information) as completed

  • d.kilic marked the checklist item no static analyzer warnings in new code parts (e.g., use clang-tidy for checking) as completed

    marked the checklist item no static analyzer warnings in new code parts (e.g., use clang-tidy for checking) as completed

  • d.kilic marked the checklist item old versions of pet-files are still loadable as completed

    marked the checklist item old versions of pet-files are still loadable as completed

  • d.kilic marked the checklist item documentation updated (if applicable) as completed

    marked the checklist item documentation updated (if applicable) as completed

  • d.kilic marked the checklist item new elements are also saved and loaded from pet-file as completed

    marked the checklist item new elements are also saved and loaded from pet-file as completed

  • d.kilic marked the checklist item check if tab order is still correct as completed

    marked the checklist item check if tab order is still correct as completed

  • d.kilic marked the checklist item all new SpinBoxes are promoted as completed

    marked the checklist item all new SpinBoxes are promoted as completed

  • d.kilic marked the checklist item new keybindings added to Petrack::keyBindings() as completed

    marked the checklist item new keybindings added to Petrack::keyBindings() as completed

  • d.kilic approved this merge request

    approved this merge request

  • merged

  • Tobias Arens mentioned in commit 791a4b1c

    mentioned in commit 791a4b1c

Please register or sign in to reply
Loading