Resolve "Delete `fix` in path-options of tracking"
Removed the 'fix' checkbox under tracking->path since it had no functionality.
Reviewer Checklist
General code quality
-
naming conventions are met (see .clang-tidy for detailed information) -
no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)
General usability
-
old versions of pet-files are still loadable -
documentation updated (if applicable)
Only if changes in UI
-
new elements are also saved and loaded from pet-file -
check if tab order is still correct -
all new SpinBoxes are promoted -
new keybindings added to Petrack::keyBindings()
Closes #511 (closed)
Edited by d.kilic
Merge request reports
Activity
added 1 commit
- 7bfc442b - Incremented minor version and added python script to update pet files more quickly (unfinished)
added 1 commit
- 41b765cb - Fixed update_pet_files script, Pipeline should succeed if it is executed
- Resolved by d.kilic
In this MR I also want to include a new script that makes updating all pet files for the demo and tests easier. Those would be the pet files the script touches (besides scipt/update_pet_files.py). The question is if some of these may not be changed. @d.kilic you might want to have a look at that.
Edited by Simon Hermanns
mentioned in issue #516 (closed)
- Resolved by Simon Hermanns
@d.kilic those are now the files that are modified. The tests succeed as well. Can I add them to my commit now or are there still some that should not be modified?
added 1 commit
- c868114c - Fixed update_pet_files and updated all pet files for the pipeline
added 13 commits
-
c868114c...d9cf891c - 2 commits from branch
master
- c6d017f3 - 1 earlier commit
- d78cf2e4 - Added back maximumSize to checkbox
- 8dc9d906 - Reverted back to normal layout to see if regression tests pass now
- 5e13e63d - formatting
- 567ebef9 - Fixed for regression test
- 43e01841 - Reverted back to first layout + formatting
- 586ceb4c - Incremented minor version and added python script to update pet files more quickly (unfinished)
- bccc3221 - Added absolute path removal with update_pet_files.py in pet files
- d65aedb1 - Fix opening all windows at the same time
- d99a6db4 - Fixed update_pet_files script, Pipeline should succeed if it is executed
- 32949386 - Fixed update_pet_files and updated all pet files for the pipeline
Toggle commit list-
c868114c...d9cf891c - 2 commits from branch
Please register or sign in to reply