Skip to content
Snippets Groups Projects

Resolve "Naming and order of file->export menu items"

Merged Resolve "Naming and order of file->export menu items"
455-naming-and-order-of-file-export-menu-items into master
Merged Simon Hermanns requested to merge 455-naming-and-order-of-file-export-menu-items into master

Under File, "Export Video View" has been renamed to "Export View Video" and moved two lines down in the menu. The layout in the export docu has been adjusted accordingly.

Reviewer Checklist

General code quality

  • naming conventions are met (see .clang-tidy for detailed information)
  • no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)

General usability

  • old versions of pet-files are still loadable
  • documentation updated (if applicable)

Only if changes in UI

  • new elements are also saved and loaded from pet-file
  • check if tab order is still correct
  • all new SpinBoxes are promoted
  • new keybindings added to Petrack::keyBindings()

Closes #455 (closed)

Edited by d.kilic

Merge request reports

Pipeline #167975 passed

Stage: docs
Stage: pre-build-checks
Stage: build
Stage: test

Pipeline passed for 52ce2d6f on 455-naming-and-order-of-file-export-menu-items

Merged by Simon HermannsSimon Hermanns 4 months ago (Oct 23, 2024 6:57am UTC)

Loading

Pipeline #170831 passed

Stage: docs
Stage: build_environment
Stage: pre-build-checks
Stage: build
Stage: test

Pipeline passed for d9cf891c on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Simon Hermanns added GUI low-effort labels

    added GUI low-effort labels

  • Simon Hermanns added 5 commits

    added 5 commits

    • 6e4c647f...34358ec8 - 2 commits from branch master
    • 49b6c63f - Renamed 'Export Video View' to 'Export View Video' and moved the entry two lines lower
    • 87c78db3 - Also adjusted name of mention in docu accordingly
    • 9a49a376 - Forgot to move the bullet point two lines down as well

    Compare with previous version

    Toggle commit list
  • d.kilic marked the checklist item naming conventions are met (see .clang-tidy for detailed information) as completed

    marked the checklist item naming conventions are met (see .clang-tidy for detailed information) as completed

  • d.kilic marked the checklist item no static analyzer warnings in new code parts (e.g., use clang-tidy for checking) as completed

    marked the checklist item no static analyzer warnings in new code parts (e.g., use clang-tidy for checking) as completed

  • d.kilic marked the checklist item old versions of pet-files are still loadable as completed

    marked the checklist item old versions of pet-files are still loadable as completed

  • d.kilic marked the checklist item documentation updated (if applicable) as completed

    marked the checklist item documentation updated (if applicable) as completed

  • d.kilic marked the checklist item new elements are also saved and loaded from pet-file as completed

    marked the checklist item new elements are also saved and loaded from pet-file as completed

  • d.kilic marked the checklist item check if tab order is still correct as completed

    marked the checklist item check if tab order is still correct as completed

  • d.kilic marked the checklist item all new SpinBoxes are promoted as completed

    marked the checklist item all new SpinBoxes are promoted as completed

  • d.kilic marked the checklist item new keybindings added to Petrack::keyBindings() as completed

    marked the checklist item new keybindings added to Petrack::keyBindings() as completed

  • d.kilic approved this merge request

    approved this merge request

  • Simon Hermanns added 7 commits

    added 7 commits

    • 9a49a376...5ec61d4e - 4 commits from branch master
    • 711aedfd - Renamed 'Export Video View' to 'Export View Video' and moved the entry two lines lower
    • fc10a88f - Also adjusted name of mention in docu accordingly
    • 52ce2d6f - Forgot to move the bullet point two lines down as well

    Compare with previous version

    Toggle commit list
  • Simon Hermanns enabled an automatic merge when all merge checks for 52ce2d6f pass

    enabled an automatic merge when all merge checks for 52ce2d6f pass

  • Simon Hermanns merged

    merged

  • Simon Hermanns mentioned in commit d9cf891c

    mentioned in commit d9cf891c

Please register or sign in to reply