Skip to content

Enable loading in videos from Hermes-Experiments

d.kilic requested to merge 37-stereo-loading-video into master

This MR enables PeTrack to again load in videos from Hermes, that is Stereo-Videos from Point Grey's Bumblebee camera.

This MR does not enable full stereo functionality (e.g. the background subtraction does not work again). Most stereo functionality was not tested at all.

This MR does reintroduce:

  • Reading PtGrey avi files
  • calculating disparities (only tested with OpenCV SGBM; best method according to Maik's thesis, p. 147)
  • drawing disparities

@a.kandler would this be enough for the documentation of the experiments?

NOTE: Changing anything about the edge mask (size or enabled/disabled) leads to a crash; leave it as is (out of scope for this MR)

Notes to the reviewer:

  • This MR also changes files in the 3rd-party repo, remember to run git submodule update, if your IDE does not do that automatically

  • The functionality is important in this MR; code quality should be improved in another MR (else this MR is going to be really large, because of the volume of the code)

  • STEREO is Windows only (we use the windows-header to read in AVI-files)

  • Merge 3rd-party repo branch into its master and update reference here

Related #37

Reviewer Checklist


  • the pre-build checks succeed

General code quality

  • naming conventions are met (see .clang-tidy for detailed information)
  • no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)

General usability

  • old versions of pet-files are still loadable

Only if changes in UI

  • new elements are also saved and loaded from pet-file
  • check if tab order is still correct
  • all new SpinBoxes are promoted
  • new keybindings added to Petrack::keyBindings()
Edited by d.kilic

Merge request reports