Skip to content
Snippets Groups Projects

Disambiguate class name vs object name; rename InterferenceFunction -> Interference

Merged Wuttke, Joachim requested to merge sb1 into develop
All threads resolved!
  • Remove the dynamic setting of names.
  • Resolve the long-standing ambiguity of class name vs object name.
  • INode now has a virtual function className; final children also have static member class_name.
  • To resolve an inconsistency between GUI and core, rename InterferenceFunction -> Interference.
  • Provide MultiLayer::setSampleName, yet unsupported in the GUI.
Edited by Wuttke, Joachim

Merge request reports

Pipeline #44181 passed

Pipeline passed for 4cdb2030 on sb1

Approval is optional

Merged by Wuttke, JoachimWuttke, Joachim 3 years ago (Aug 26, 2021 10:53am UTC)

Merge details

  • Changes merged into develop with 51bc5291.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #44183 passed

Pipeline passed for 51bc5291 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Wuttke, Joachim resolved all threads

    resolved all threads

  • m.puchner
  • m.puchner
  • added 1 commit

    • 8ae9203e - in ConnectableView, correct name -> getViewName

    Compare with previous version

  • added 1 commit

    • 8d2558b1 - ConnectableView: rm m_name for good

    Compare with previous version

  • Wuttke, Joachim added 2 commits

    added 2 commits

    • 8d51703c - Under INode, provide static class_name
    • 0a8f7d82 - MultiLayer + m_sample_name

    Compare with previous version

  • added 1 commit

    • c8e73a7a - corrected fct name -> setMaterialItemName

    Compare with previous version

  • Wuttke, Joachim added 2 commits

    added 2 commits

    • 582f051e - GUIDomainSampleVisitor: use Multilayer::sampleName()
    • 994b45ec - PyImportAssistant: use Multilayer::sampleName()

    Compare with previous version

  • Wuttke, Joachim changed the description

    changed the description

  • added 1 commit

    • 4cdb2030 - GUI: instrumentName(), dataName()

    Compare with previous version

  • Wuttke, Joachim resolved all threads

    resolved all threads

  • Wuttke, Joachim enabled an automatic merge when the pipeline for 4cdb2030 succeeds

    enabled an automatic merge when the pipeline for 4cdb2030 succeeds

  • Wuttke, Joachim mentioned in commit 51bc5291

    mentioned in commit 51bc5291

  • Please register or sign in to reply
    Loading