Skip to content
Snippets Groups Projects

remove changing values directly and only deactivating params after calibration...

All threads resolved!

Changing values in the ui when clicking e.g. fixCenter is incorrect.
The user needs to recalibrate to bring his changes into effect

Closes #474 (closed)

ToDo

  • user needs to be made aware he has to recalibrate

Reviewer Checklist

Formatting

  • the pre-build checks succeed

General code quality

  • naming conventions are met (see .clang-tidy for detailed information)
  • no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)

General usability

  • old versions of pet-files are still loadable

Only if changes in UI

  • new elements are also saved and loaded from pet-file
  • check if tab order is still correct
  • all new SpinBoxes are promoted
  • new keybindings added to Petrack::keyBindings()
Edited by d.kilic

Merge request reports

Test summary results are being parsed

Merged by l.dressenl.dressen 1 year ago (Mar 7, 2024 1:41pm UTC)

Merge details

Pipeline #135018 passed

Pipeline passed for cd9bbc08 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • l.dressen added 2 commits

    added 2 commits

    • 247e944e - review comments + increment petrack version
    • 8a90589d - change last path for autocalib instead of actually adding a calib file

    Compare with previous version

  • l.dressen marked the checklist item user needs to be made aware he has to recalibrate as completed

    marked the checklist item user needs to be made aware he has to recalibrate as completed

  • l.dressen added 1 commit

    added 1 commit

    Compare with previous version

  • l.dressen marked this merge request as ready

    marked this merge request as ready

  • d.kilic marked the checklist item the pre-build checks succeed as completed

    marked the checklist item the pre-build checks succeed as completed

  • d.kilic marked the checklist item naming conventions are met (see .clang-tidy for detailed information) as completed

    marked the checklist item naming conventions are met (see .clang-tidy for detailed information) as completed

  • d.kilic marked the checklist item no static analyzer warnings in new code parts (e.g., use clang-tidy for checking) as completed

    marked the checklist item no static analyzer warnings in new code parts (e.g., use clang-tidy for checking) as completed

  • d.kilic marked the checklist item old versions of pet-files are still loadable as completed

    marked the checklist item old versions of pet-files are still loadable as completed

  • d.kilic
  • d.kilic
  • d.kilic
  • d.kilic
    • Resolved by d.kilic

      We already discussed this, but to put it into writing:

      The .pet-file should always contain the checkbox-states with which the project was calibrated. In the case that the user selects "continue with current calibration", this is not the same as the currently selected checkboxes.

  • l.dressen added 1 commit

    added 1 commit

    • b7661715 - review comments + calibSettings struct

    Compare with previous version

  • d.kilic
  • d.kilic
  • d.kilic
  • l.dressen added 1 commit

    added 1 commit

    • 42e01a4a - setCalibsettings after successful calibration, added testcase for changing...

    Compare with previous version

  • d.kilic
  • The only thing left is kind of a nitpick. Please resolve it yourself after you addressed it and merge this; I'll already approve this MR

  • d.kilic approved this merge request

    approved this merge request

  • l.dressen added 1 commit

    added 1 commit

    Compare with previous version

  • l.dressen resolved all threads

    resolved all threads

  • l.dressen added 5 commits

    added 5 commits

    Compare with previous version

  • l.dressen enabled an automatic merge when the pipeline for 6a3c10e0 succeeds

    enabled an automatic merge when the pipeline for 6a3c10e0 succeeds

  • merged

  • l.dressen mentioned in commit cd9bbc08

    mentioned in commit cd9bbc08

  • Please register or sign in to reply
    Loading