remove changing values directly and only deactivating params after calibration...
Merged
requested to merge 474-remove-immediate-change-of-values-when-e-g-fixcenter-is-checked into master
All threads resolved!
Changing values in the ui when clicking e.g. fixCenter is incorrect.
The user needs to recalibrate to bring his changes into effect
Closes #474 (closed)
ToDo
-
user needs to be made aware he has to recalibrate
Reviewer Checklist
Formatting
-
the pre-build checks succeed
General code quality
-
naming conventions are met (see .clang-tidy for detailed information) -
no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)
General usability
-
old versions of pet-files are still loadable
Only if changes in UI
-
new elements are also saved and loaded from pet-file -
check if tab order is still correct -
all new SpinBoxes are promoted -
new keybindings added to Petrack::keyBindings()
Edited by d.kilic
Merge request reports
Activity
changed milestone to %1.0.0 - old
added GUI calibration labels
assigned to @l.dressen
- Resolved by d.kilic
- Resolved by d.kilic
- Resolved by d.kilic
- Resolved by d.kilic
- Resolved by d.kilic
- Resolved by d.kilic
We already discussed this, but to put it into writing:
The .pet-file should always contain the checkbox-states with which the project was calibrated. In the case that the user selects "continue with current calibration", this is not the same as the currently selected checkboxes.
- Resolved by d.kilic
- Resolved by d.kilic
- Resolved by d.kilic
added 1 commit
- 42e01a4a - setCalibsettings after successful calibration, added testcase for changing...
- Resolved by l.dressen
added 5 commits
-
dbc76e0a...8dade8b9 - 4 commits from branch
master
- 6a3c10e0 - Merge remote-tracking branch 'origin/master' into...
-
dbc76e0a...8dade8b9 - 4 commits from branch
enabled an automatic merge when the pipeline for 6a3c10e0 succeeds
mentioned in commit cd9bbc08
Please register or sign in to reply