Skip to content
Snippets Groups Projects

Unit-tests for ui are missing in CMakeLists.txt

Merged l.dressen requested to merge 471-unit-tests-for-ui-are-missing-in-cmakelists-txt into master

Add ui to CMakeLists.txt

Reviewer Checklist

Formatting

  • the pre-build checks succeed

General code quality

  • naming conventions are met (see .clang-tidy for detailed information)
  • no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)

General usability

  • old versions of pet-files are still loadable

Only if changes in UI

  • new elements are also saved and loaded from pet-file
  • check if tab order is still correct
  • all new SpinBoxes are promoted
  • new keybindings added to Petrack::keyBindings()
Edited by l.dressen

Merge request reports

Pipeline #131089 passed

Pipeline passed for aca85769 on 471-unit-tests-for-ui-are-missing-in-cmakelists-txt

Merged by l.dressenl.dressen 1 year ago (Feb 21, 2024 7:57am UTC)

Loading

Pipeline #132120 passed

Pipeline passed for 647a9657 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading