Skip to content
Snippets Groups Projects

Resolve "Add method for vector rotation for converting to world coordinate system"

Implemented requested method and added unit tests for it.

Closes #327 (closed)

Merge request reports

Pipeline #75160 passed

Pipeline passed for 21769228 on 327-add-method-for-vector-rotation-for-converting-to-world-coordinate-system

Approved by

Merged by Tobias ArensTobias Arens 2 years ago (Sep 12, 2022 7:51am UTC)

Merge details

  • Changes merged into master with d33fe0c5 (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #75334 passed

Pipeline passed for d33fe0c5 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tobias Arens resolved all threads

    resolved all threads

  • Tobias Arens added 1 commit

    added 1 commit

    • 76b963e7 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Schrödter, Tobias
  • Mostly some technical remarks, from the content it looks good to me. If you have any question to one of the remarks, don't hesitate to ask!

  • Tobias Arens added 3 commits

    added 3 commits

    • 93c4305e - renaming to naming conventions
    • 38885078 - resolved merge request comments i.e. replacing macros, formatting
    • 0526d635 - Merge branch...

    Compare with previous version

  • Tobias Arens added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    corrected all remarks

  • Tobias Arens added 1 commit

    added 1 commit

    • b3c6d77c - add const to method signature

    Compare with previous version

  • Schrödter, Tobias resolved all threads

    resolved all threads

  • Schrödter, Tobias approved this merge request

    approved this merge request

  • Tobias Arens added 18 commits

    added 18 commits

    Compare with previous version

  • Tobias Arens enabled an automatic merge when the pipeline for 21769228 succeeds

    enabled an automatic merge when the pipeline for 21769228 succeeds

  • merged

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading