Skip to content
Snippets Groups Projects

Replace all Q(Double)SpinBoxes with P(Double)SpinBoxes

Merged d.kilic requested to merge 302-disable-scrolling-in-spinboxes-when-not-desired into master

This MR replaces all (check via textsearch in control.ui) spinboxes with custom boxes by promotion in the ui-editor. The custom spinboxes ignore the wheel event, i.e. can not be changed with the mouse wheel.

This MR does not touch sliders. Sliders can still be changed by scrolling and spinboxes connected to sliders (i.e. translation of coordinate system) are changed as well, when the slider is changed by scrolling.

We may discuss whether there are spinboxes where we want the behaviour to change the value by scrolling. This could be done after this MR was merged, since reverting the change for some spinboxes is easy and quickly done.

Closes #302 (closed)

Merge request reports

Approved by
Test summary results are being parsed

Merged by d.kilicd.kilic 2 years ago (Sep 1, 2022 6:21am UTC)

Merge details

  • Changes merged into master with 796b8842 (commits were squashed).
  • Did not delete the source branch.

Pipeline #74209 passed

Pipeline passed for 796b8842 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading