Skip to content
Snippets Groups Projects

Remove net oriented sample editor

Merged m.puchner requested to merge removeNetOrientedSampleDesigner into develop

This removes the UI and all code related to the net oriented sample designer.

Merge request reports

Pipeline #49526 passed

Pipeline passed for 953f6abd on removeNetOrientedSampleDesigner

Approved by

Merged by m.puchnerm.puchner 3 years ago (Nov 16, 2021 11:48am UTC)

Merge details

  • Changes merged into develop with dd2010b7.
  • Deleted the source branch.

Pipeline #49542 passed

Pipeline passed for dd2010b7 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added GUI cleanup labels

  • m.puchner requested review from @j.wuttke

    requested review from @j.wuttke

  • Could it be that this big reduction leaves some more functions, in other places, unused? Which tools would you apply to detect those?

  • Wuttke, Joachim approved this merge request

    approved this merge request

  • Author Contributor
    • I was checking/following the includes of each removed file
    • I was using ReSharper to detect unused code

    Right now, there is nothing unused left afaics. However, certain code was/is only present to support the deleted sample editor. E.g. many of the tooltips have a been set for the net oriented sample editor, and have been set a second time for the layer editor (because for the old editor the tooltips had to contain the unit, for the new one the units are not allowed due to the new switch-unit-feature). Such code has to be removed still. It is not "never used", but "not necessary". Therefore it is not detectable by any tool, only by experience.

    In the next MRs I will address things like this (next to some UI improvements/changings to harmonize apperarance and code usage).

  • merged

  • m.puchner mentioned in commit dd2010b7

    mentioned in commit dd2010b7

Please register or sign in to reply
Loading