Skip to content
Snippets Groups Projects

Remove PkgConfig dependence on Windows

Merged Ammar Nejati requested to merge removePkgConfigDep_Win into develop
All threads resolved!

PkgConfig works properly only on Linux. On Windows, it is part of the MSYS2 platform and there is no guarantee that it works properly; it is also not necessary.

Instead of using PkgConfig, a CMake module FindPkgVersionWin is introduced to find the version of a package from a config file.

find_pkg_version_win function is used to find the version of cerf package under Windows.

Related to issue #133 (closed)

Edited by Ammar Nejati

Merge request reports

Pipeline #47612 passed

Pipeline passed for 9cb8f61e on removePkgConfigDep_Win

Merged by Ammar NejatiAmmar Nejati 3 years ago (Oct 22, 2021 10:10am UTC)

Merge details

  • Changes merged into with ae7af93b.
  • Deleted the source branch.

Pipeline #47614 passed

Pipeline passed for ae7af93b on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sorry, quite a number of review comments this time. Please ask me to review again when all threads are closed.

  • Ammar Nejati added 1 commit

    added 1 commit

    • 1f23f46c - CMake: Correct indentation (Minor change)

    Compare with previous version

  • Ammar Nejati added 1 commit

    added 1 commit

    • 403488c6 - CMake: Move `AssertLibraryFunction` and `FindPkgVersion` to `cmake/commons` folder

    Compare with previous version

  • Ammar Nejati added 1 commit

    added 1 commit

    • 52688f40 - CMake: Move `AssertLibraryFunction` and `FindPkgVersion` to `cmake/commons` folder

    Compare with previous version

  • Ammar Nejati added 1 commit

    added 1 commit

    • 6364fe0d - CMake: Add documentation to FindPkgVersion module

    Compare with previous version

  • Ammar Nejati added 1 commit

    added 1 commit

    • 304f7da9 - FindPkgVersion: Slightly improve code; rem unnecessary comments

    Compare with previous version

  • Ammar Nejati added 1 commit

    added 1 commit

    • 11099e9b - CMake: Rename 'FindPkgVersion' -> 'FindPkgVersionWin'

    Compare with previous version

  • Ammar Nejati added 2 commits

    added 2 commits

    • c6177531 - FindPkgVersion: Slightly improve code; rem unnecessary comments
    • f0eb94f0 - CMake: Rename 'FindPkgVersion' -> 'FindPkgVersionWin'

    Compare with previous version

  • Ammar Nejati added 1 commit

    added 1 commit

    • a5f8df0e - CMake: Rename 'FindPkgVersion' -> 'FindPkgVersionWin'

    Compare with previous version

  • Ammar Nejati added 2 commits

    added 2 commits

    • b8cb49d5 - FindPkgVersion: Slightly improve code; rem unnecessary comments
    • 992afd4c - CMake: Rename 'FindPkgVersion' -> 'FindPkgVersionWin'

    Compare with previous version

  • Ammar Nejati added 1 commit

    added 1 commit

    • eccc16f0 - CMake: Rename 'FindPkgVersion' -> 'FindPkgVersionWin'

    Compare with previous version

  • Ammar Nejati added 1 commit

    added 1 commit

    • 350ffd3f - CMake: Rename 'FindPkgVersion' -> 'FindPkgVersionWin'

    Compare with previous version

  • Ammar Nejati added 2 commits

    added 2 commits

    • 4b56e70a - FindPkgVersion: Slightly improve code; rem unnecessary comments
    • 490e9307 - CMake: Rename 'FindPkgVersion' -> 'FindPkgVersionWin'

    Compare with previous version

  • Ammar Nejati changed the description

    changed the description

  • Ammar Nejati resolved all threads

    resolved all threads

  • 2 threads, no need for further review, thanks.

  • Ammar Nejati added 3 commits

    added 3 commits

    • 0bfba9f5 - CMake: Add documentation to FindPkgVersion module
    • c55c6b01 - FindPkgVersion: Improve code; rem unnecessary comments
    • 9cb8f61e - CMake: Rename 'FindPkgVersion' -> 'FindPkgVersionWin'

    Compare with previous version

  • Ammar Nejati resolved all threads

    resolved all threads

  • Ammar Nejati mentioned in commit ae7af93b

    mentioned in commit ae7af93b

  • merged

  • mentioned in issue #133 (closed)

  • Please register or sign in to reply
    Loading