Skip to content
Snippets Groups Projects

GUI: rm SelectionDescriptor for detector alignment

Merged Mikhail Svechnikov requested to merge from_SelectionDescriptor_3.1 into main

Rectangular detector alignment is now handled without creating a SelectionDescriptor.

Steps of SelectionProperty/Descriptor refactoring:

  1. make SelectionProperty less generic, make catalogs usage mandatory, not optional
  2. reduce usage of ad hoc SelectionDescriptors, e.g. descriptors that are not derived from SelectionProperty
  3. move Descriptor functionality to Property
  4. use Property instead of Descriptor
  5. remove Descriptor from code
  6. refactor serialization of Property

This MR is related to points 2.

Edited by Mikhail Svechnikov

Merge request reports

Pipeline #82419 passed

Pipeline passed for 1841d973 on from_SelectionDescriptor_3.1

Approved by

Merged by Mikhail SvechnikovMikhail Svechnikov 2 years ago (Dec 7, 2022 9:40am UTC)

Merge details

  • Changes merged into main with d1632bea.
  • Deleted the source branch.

Pipeline #82457 passed

Pipeline passed for d1632bea on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading