Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
BornAgain
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
mlz
BornAgain
Commits
a64ba4ff
Commit
a64ba4ff
authored
2 years ago
by
Mikhail Svechnikov
Browse files
Options
Downloads
Plain Diff
[i445] GUI: switch to 'Message' tab for failed job (Closes
#445
)
Merging branch 'i445' into 'main'. See merge request
!1349
parents
dbcfb487
539e936b
No related branches found
No related tags found
1 merge request
!1349
GUI: switch to 'Message' tab for failed job
Pipeline
#89300
passed
2 years ago
Stage: build
Changes
3
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
GUI/Model/Model/JobQueueData.cpp
+1
-0
1 addition, 0 deletions
GUI/Model/Model/JobQueueData.cpp
GUI/View/Job/JobPropertiesWidget.cpp
+3
-2
3 additions, 2 deletions
GUI/View/Job/JobPropertiesWidget.cpp
GUI/View/Job/JobView.cpp
+2
-5
2 additions, 5 deletions
GUI/View/Job/JobView.cpp
with
6 additions
and
7 deletions
GUI/Model/Model/JobQueueData.cpp
+
1
−
0
View file @
a64ba4ff
...
...
@@ -57,6 +57,7 @@ void JobQueueData::runJob(JobItem* jobItem)
jobItem
->
setComments
(
message
);
jobItem
->
setProgress
(
100
);
jobItem
->
setStatus
(
JobStatus
::
Failed
);
clearSimulation
(
identifier
);
emit
focusRequest
(
jobItem
);
return
;
}
...
...
This diff is collapsed.
Click to expand it.
GUI/View/Job/JobPropertiesWidget.cpp
+
3
−
2
View file @
a64ba4ff
...
...
@@ -86,9 +86,10 @@ void JobPropertiesWidget::setJobItem(JobItem* jobItem)
m_jobItem
=
jobItem
;
m_propertiesModel
->
setJobItem
(
m_jobItem
);
if
(
m_jobItem
)
{
if
(
m_jobItem
->
isFailed
())
if
(
m_jobItem
->
isFailed
())
{
m_tabWidget
->
tabBar
()
->
setTabTextColor
(
JOB_MESSAGES
,
Qt
::
red
);
else
m_tabWidget
->
setCurrentIndex
(
JOB_MESSAGES
);
}
else
m_tabWidget
->
tabBar
()
->
setTabTextColor
(
JOB_MESSAGES
,
Qt
::
black
);
m_commentsEditor
->
setText
(
m_jobItem
->
comments
());
...
...
This diff is collapsed.
Click to expand it.
GUI/View/Job/JobView.cpp
+
2
−
5
View file @
a64ba4ff
...
...
@@ -59,11 +59,8 @@ void JobView::onFocusRequest(JobItem* jobItem)
if
(
jobItem
->
runInBackground
())
return
;
QVector
<
JobItem
*>
jobs
=
m_jobSelector
->
selectedJobItems
();
if
(
jobs
.
size
()
!=
1
||
jobItem
!=
jobs
.
front
())
{
m_jobSelector
->
makeJobItemSelected
(
jobItem
);
setActivityAndPresentationForNewJob
(
jobItem
);
}
m_jobSelector
->
makeJobItemSelected
(
jobItem
);
setActivityAndPresentationForNewJob
(
jobItem
);
emit
focusRequest
(
GUI
::
ID
::
Job
);
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment