Skip to content
Snippets Groups Projects
Commit 3fae2f1e authored by Mikhail Svechnikov's avatar Mikhail Svechnikov
Browse files

BasicAxisItem: rm P_TITLE_IS_VISIBLE

parent 5fd171ba
No related branches found
No related tags found
1 merge request!1026GUI: simplify access to SessionItem properties
...@@ -81,25 +81,15 @@ void BasicAxisItem::setTitle(const QString& title) ...@@ -81,25 +81,15 @@ void BasicAxisItem::setTitle(const QString& title)
emit axisTitleChanged(); emit axisTitleChanged();
} }
bool BasicAxisItem::isTitleVisible() const
{
return getItemValue(P_TITLE_IS_VISIBLE).toBool();
}
std::unique_ptr<IAxis> BasicAxisItem::createAxis(double scale) const std::unique_ptr<IAxis> BasicAxisItem::createAxis(double scale) const
{ {
return std::make_unique<FixedBinAxis>(title().toStdString(), binCount(), min() * scale, return std::make_unique<FixedBinAxis>(title().toStdString(), binCount(), min() * scale,
max() * scale); max() * scale);
} }
SessionItem* BasicAxisItem::visibilityItem() const
{
return getItem(P_IS_VISIBLE);
}
bool BasicAxisItem::isVisible() const bool BasicAxisItem::isVisible() const
{ {
return visibilityItem()->value().toBool(); return getItemValue(P_MIN_DEG).toBool();
} }
void BasicAxisItem::setVisibilityValue(bool b) void BasicAxisItem::setVisibilityValue(bool b)
...@@ -118,7 +108,6 @@ BasicAxisItem::BasicAxisItem(const QString& type) ...@@ -118,7 +108,6 @@ BasicAxisItem::BasicAxisItem(const QString& type)
addProperty(P_MIN_DEG, 0.0)->setDecimals(3).setLimits(RealLimits::limitless()); addProperty(P_MIN_DEG, 0.0)->setDecimals(3).setLimits(RealLimits::limitless());
addProperty(P_MAX_DEG, -1.0)->setDecimals(3).setLimits(RealLimits::limitless()); addProperty(P_MAX_DEG, -1.0)->setDecimals(3).setLimits(RealLimits::limitless());
addProperty(P_TITLE, QString()); addProperty(P_TITLE, QString());
addProperty(P_TITLE_IS_VISIBLE, true);
} }
void BasicAxisItem::serialize(Streamer& s) void BasicAxisItem::serialize(Streamer& s)
...@@ -129,7 +118,6 @@ void BasicAxisItem::serialize(Streamer& s) ...@@ -129,7 +118,6 @@ void BasicAxisItem::serialize(Streamer& s)
Serialize::rwSessionItem<double>(s, "min", getItem(P_MIN_DEG)); Serialize::rwSessionItem<double>(s, "min", getItem(P_MIN_DEG));
Serialize::rwSessionItem<double>(s, "max", getItem(P_MAX_DEG)); Serialize::rwSessionItem<double>(s, "max", getItem(P_MAX_DEG));
Serialize::rwSessionItem<QString>(s, "title", getItem(P_TITLE)); Serialize::rwSessionItem<QString>(s, "title", getItem(P_TITLE));
Serialize::rwSessionItem<bool>(s, "titleVisible", getItem(P_TITLE_IS_VISIBLE));
} }
// ---------------------------------------------------------------------------------------------- // // ---------------------------------------------------------------------------------------------- //
...@@ -139,7 +127,6 @@ AmplitudeAxisItem::AmplitudeAxisItem() ...@@ -139,7 +127,6 @@ AmplitudeAxisItem::AmplitudeAxisItem()
{ {
addProperty(P_LOCK_MIN_MAX, false); addProperty(P_LOCK_MIN_MAX, false);
addProperty(P_IS_LOGSCALE, true); addProperty(P_IS_LOGSCALE, true);
visibilityItem();
} }
void AmplitudeAxisItem::serialize(Streamer& s) void AmplitudeAxisItem::serialize(Streamer& s)
......
...@@ -30,7 +30,6 @@ private: ...@@ -30,7 +30,6 @@ private:
static constexpr auto P_MIN_DEG{"Min [deg]"}; static constexpr auto P_MIN_DEG{"Min [deg]"};
static constexpr auto P_MAX_DEG{"Max [deg]"}; static constexpr auto P_MAX_DEG{"Max [deg]"};
static constexpr auto P_TITLE{"Title"}; static constexpr auto P_TITLE{"Title"};
static constexpr auto P_TITLE_IS_VISIBLE{"Title Visibility"};
public: public:
static constexpr auto M_TYPE{"BasicAxis"}; static constexpr auto M_TYPE{"BasicAxis"};
...@@ -54,11 +53,9 @@ public: ...@@ -54,11 +53,9 @@ public:
QString title() const; QString title() const;
void setTitle(const QString& title); void setTitle(const QString& title);
bool isTitleVisible() const;
virtual std::unique_ptr<IAxis> createAxis(double scale) const; virtual std::unique_ptr<IAxis> createAxis(double scale) const;
SessionItem* visibilityItem() const;
bool isVisible() const; bool isVisible() const;
void setVisibilityValue(bool b); void setVisibilityValue(bool b);
......
...@@ -337,17 +337,11 @@ void ColorMap::setAxesLabelsFromItem() ...@@ -337,17 +337,11 @@ void ColorMap::setAxesLabelsFromItem()
{ {
if (!intensityItem()) if (!intensityItem())
return; return;
if (intensityItem()->xAxisItem()->isTitleVisible())
m_customPlot->xAxis->setLabel(intensityItem()->XaxisTitle());
else
m_customPlot->xAxis->setLabel(QString());
m_customPlot->xAxis->setLabel(intensityItem()->XaxisTitle());
m_customPlot->yAxis->setLabel(intensityItem()->YaxisTitle());
m_colorScale->setMargins(QMargins(0, 0, 0, 0)); m_colorScale->setMargins(QMargins(0, 0, 0, 0));
if (intensityItem()->yAxisItem()->isTitleVisible())
m_customPlot->yAxis->setLabel(intensityItem()->YaxisTitle());
else
m_customPlot->yAxis->setLabel(QString());
replot(); replot();
} }
......
...@@ -239,10 +239,7 @@ void SpecularPlot::setAxesLabels() ...@@ -239,10 +239,7 @@ void SpecularPlot::setAxesLabels()
void SpecularPlot::setLabel(const BasicAxisItem* item, QCPAxis* axis) void SpecularPlot::setLabel(const BasicAxisItem* item, QCPAxis* axis)
{ {
ASSERT(item && axis); ASSERT(item && axis);
if (item->isTitleVisible()) axis->setLabel(item->title());
axis->setLabel(item->title());
else
axis->setLabel(QString());
} }
void SpecularPlot::setDataFromItem(SpecularDataItem* item) void SpecularPlot::setDataFromItem(SpecularDataItem* item)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment