Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • PeTrack PeTrack
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
  • Issues 119
    • Issues 119
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Pedestrian Dynamics Empiricism
  • PeTrackPeTrack
  • Merge requests
  • !141

Add extra tab for trajectory tests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Schrödter, Tobias requested to merge 214-add-extra-tab-for-tracking-tests into master Oct 26, 2021
  • Overview 50
  • Commits 25
  • Pipelines 8
  • Changes 13

Adds an extra tab for the included trajectory tests. The desired tests can be enabled via checkboxes, and the results are displayed in a table. A click on a row jumps to the corresponding frame and shows only the pedestrian for whom the test failed.

Implementation details:

  • Make checkPlausibility a free function
  • Create extra QWidget for the content of the new tab (trying not to increase complexity of control more)

Open ToDos:

  • button to run the tests
  • check boxes to enable/disable tests
  • parameters for the tests
  • table which shows the results of the tests
  • click on an entry of the test should jump to the frame with the issue
  • row should contain a resolve button which marks the tests as resolved at deletes it from the table (may reappear if run test is clicked again
  • Change error-string (delete part with frame and person-number)

Closes #214

Reviewer Checklist

Formatting

  • the pre-build checks succeed

General code quality

  • naming conventions are met (see .clang-tidy for detailed information)
  • no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)

General usability

  • old versions of pet-files are still loadable

Only if changes in UI

  • new elements are also saved and loaded from pet-file
  • check if tab order is still correct
  • all new SpinBoxes are promoted
  • new keybindings added to Petrack::keyBindings()
Edited Mar 22, 2023 by Schrödter, Tobias
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 214-add-extra-tab-for-tracking-tests