Core: confusing class name Integrator
Directory core/integration holds source pair Integrator.h|cpp, which defines class Integrator
, which is not the parent of all the other *Integrator
classes in the same directory. Rather, these inherit from class IPeakIntegrator
, which however is not defined in directory core/integration, but in directory core/shape. This is confusing.
Source pair Integrator.h|cpp could be moved to core/experiment, which is the only place where Integrator.h is included. The class should be renamed to something like IntegrationEngine
or IntegrationWrapper
.
IPeakIntegrator.h|cpp should be be moved to core/integration, and the class could be renamed to IIntegrator
.