Skip to content
Snippets Groups Projects

CMake cleanup: rm variable BA_PLATFORM, sort sections, require 64-bit platform.

Merged CMake cleanup: rm variable BA_PLATFORM, sort sections, require 64-bit platform.
j.2 into main
All threads resolved!
Merged Wuttke, Joachim requested to merge j.2 into main
All threads resolved!

Replaces !2503 (closed).

No more attempt to predict wheel name, just some cleanup.

Merge request reports

Pipeline #139221 passed

Stage: build

Pipeline passed for 49703fd7 on j.2

Approval is optional

Merged by Wuttke, JoachimWuttke, Joachim 11 months ago (Apr 19, 2024 10:52am UTC)

Merge details

  • Changes merged into main with a8ff3856.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #139227 passed

Stage: build

Pipeline passed for a8ff3856 on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ammar Nejati
    Ammar Nejati @a.nejati ·
    Owner

    The only serious problem I see is deciding the name of the Python wheel.

    Otherwise, the it is a clean up of unsupported 32bit architecture, which is valid and needed.

  • Wuttke, Joachim resolved all threads

    resolved all threads

  • Ammar Nejati
  • Wuttke, Joachim added 1 commit

    added 1 commit

    • 49703fd7 - sort sections in top-level CMakeLists; obtain BA_WHEEL_NAME

    Compare with previous version

  • Wuttke, Joachim resolved all threads

    resolved all threads

  • Wuttke, Joachim enabled an automatic merge when the pipeline for 49703fd7 succeeds

    enabled an automatic merge when the pipeline for 49703fd7 succeeds

  • Wuttke, Joachim merged

    merged

  • Wuttke, Joachim mentioned in commit a8ff3856

    mentioned in commit a8ff3856

    • Please register or sign in to reply