Draft: GUI: minor improvements from i373 (!1216) · Merge requests · mlz / BornAgain

Mikhail Svechnikov requested to merge i373 into main Dec 22, 2022

Resolves the following points from #373 (closed):

Several using CatalogedType = ... declarations seem to be unused. Append explanatory comment // used in SelectionProperty<Catalog>.
In RotationsItemCatalog.h, comment "Available types of interference items" seems to contain a copy&paste error. As this is boilerplate code, keep the comment short, and same for all similar classes.
At several places, typo "than" where it should be "then". Grep for "than" in entire GUI directory please.
struct UiInfo is declared in identical way in many classes. Why not declare it at global level?
In FormFactorItemCatalog (and elsewhere), instead of macro name CHECK, which evokes testing, maybe RETURN_IF?

Edited Dec 22, 2022 by Mikhail Svechnikov

Draft: GUI: minor improvements from i373