GUI: delete SelectionDescriptors class (!1176) · Merge requests · mlz / BornAgain · GitLab

Snippets Groups Projects

Merged Mikhail Svechnikov requested to merge from_SelectionDescriptors_4 into main 2 years ago

All threads resolved!

SelectionDescriptor is completely removed from code and replaced by SelectionProperty.

Steps of SelectionProperty/Descriptor refactoring:

make SelectionProperty less generic, make catalogs usage mandatory, not optional
reduce usage of ad hoc SelectionDescriptors, e.g. descriptors that are not derived from SelectionProperty
move Descriptor functionality to Property
use Property instead of Descriptor
remove Descriptor from code
refactor serialization of Property

This MR does points 3,4,5.

Edited 2 years ago by Mikhail Svechnikov

Activity

Mikhail Svechnikov added GUI simplify labels 2 years ago

added GUI simplify labels
Mikhail Svechnikov requested review from @j.wuttke 2 years ago

requested review from @j.wuttke
Mikhail Svechnikov assigned to @m.svechnikov 2 years ago

assigned to @m.svechnikov
Mikhail Svechnikov added 1 commit 2 years ago
added 1 commit

41d56236 - naming fixes

Compare with previous version
Mikhail Svechnikov marked this merge request as ready 2 years ago

marked this merge request as ready
Mikhail Svechnikov changed the description 2 years ago

changed the description
Wuttke, Joachim @j.wuttke started a thread on the diff 2 years ago

Resolved 2 years ago by Mikhail Svechnikov
Last reply by Mikhail Svechnikov 2 years ago

Wuttke, Joachim @j.wuttke started a thread on the diff 2 years ago

Resolved 2 years ago by Wuttke, Joachim

Wuttke, Joachim approved this merge request 2 years ago

approved this merge request

Wuttke, Joachim resolved all threads 2 years ago

resolved all threads

Mikhail Svechnikov merged 2 years ago

merged

Mikhail Svechnikov mentioned in commit 2 years ago

mentioned in commit 44b98dad

Please register or sign in to reply