Skip to content
Snippets Groups Projects

GUI: interfaces and argument types: DoubleDescriptor ---> DoubleProperty

Merged GUI: interfaces and argument types: DoubleDescriptor ---> DoubleProperty
from_DoubleDescriptor_6 into main
All threads resolved!
Merged Mikhail Svechnikov requested to merge from_DoubleDescriptor_6 into main
All threads resolved!

Interfaces of accepting functions are changed from DoubleDescriptor to DoubleProperty. Not everywhere, so one more MR will continue this work.

Steps of Descriptor refactoring:

  1. reduce usage of functional pointers set() and get() of DoubleDescriptor
  2. move Descriptor functionality to Property
  3. use Property instead of Descriptor
  4. remove Descriptor from code
  5. refactor serialization of Property
  6. replace Property macro definitions like DOUBLE_PROPERTY(intensity, Intensity) by explicit member with setter and getter

This MR does 3 for DoubleDescriptor

Edited by Mikhail Svechnikov

Merge request reports

Pipeline #81780 passed

Stage: build

Pipeline passed for 5478cf1f on from_DoubleDescriptor_6

Approved by
Wuttke, Joachim

Merged by Mikhail SvechnikovMikhail Svechnikov 2 years ago (Dec 1, 2022 2:15pm UTC)

Merge details

  • Changes merged into main with afba408c.
  • Deleted the source branch.

Pipeline #81886 passed

Stage: build

Pipeline passed for afba408c on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mikhail Svechnikov resolved all threads

    resolved all threads

  • Wuttke, Joachim approved this merge request

    approved this merge request

  • Mikhail Svechnikov merged

    merged

  • Mikhail Svechnikov mentioned in commit afba408c

    mentioned in commit afba408c

    • Please register or sign in to reply