Ambiguous analyzer for OffspecSimulation

OffspecSimulation contains and uses members OffspecDetector and IBeamScan and each of them has its own analyzer.

Now IBeamScan::analyzerMatrix() is used for computation in OffspecSimulation::runComputation.

For reasons of consistency, we should use OffspecDetector::analyzer().matrix() instead.

Moreover, IBeamScan::analyzerMatrix() should be hidden (only for offspec) from users to prevent ambiguity.

added polarization label

changed the description

changed title from Ambiguous polarizer for OffspecSimulation to Ambiguous analyzer for OffspecSimulation

changed the description

mentioned in issue #656 (closed)

marked this issue as related to #656 (closed)

changed milestone to %offspec

marked this issue as related to #649 (closed)

assigned to @m.svechnikov

mentioned in merge request !1896 (merged)

mentioned in commit 4d2b4fc2

closed with merge request !1896 (merged)