check for empty projectDir

GUI/Model/Data/DataItem.cpp

@@ -90,8 +90,11 @@ bool DataItem::containsNonXMLData() const
     return static_cast<bool>(m_datafield);
 }
 
-QString DataItem::loadDatafield(const QString& projectDir, MessageService* messageService)
+QString DataItem::loadDatafield(MessageService* messageService, const QString& projectDir)
 {
+    if (projectDir.isEmpty())
+        return {};
+
     ASSERT(messageService);
     const QString filename = fileName(projectDir);
     try {
@@ -123,7 +126,7 @@ bool DataItem::saveDatafield(const QString& projectDir)
 
 void DataItem::saveDatafieldInBackground(const QString &projectDir)
 {
-    if (!containsNonXMLData() || !isModifiedSinceLastSave())
+    if (!containsNonXMLData() || !isModifiedSinceLastSave() || projectDir.isEmpty())
         return;
 
     std::unique_lock<std::mutex> lock(m_update_data_mutex);

GUI/Model/Data/DataItem.h

@@ -56,9 +56,9 @@ public:
     void setFileName(const QString& filename);
     QDateTime lastModified() const override;
     bool containsNonXMLData() const override;
-    QString loadDatafield(const QString& projectDir, MessageService* messageService) override;
+    QString loadDatafield(MessageService* messageService, const QString& projectDir = "") override;
     bool saveDatafield(const QString& projectDir) override;
-    void saveDatafieldInBackground(const QString& projectDir);
+    void saveDatafieldInBackground(const QString& projectDir = "");
 
     void setLastModified(const QDateTime& dtime);
 

GUI/Model/Data/RealItem.cpp

@@ -423,13 +423,13 @@ QString RealItem::readFrom(QXmlStreamReader* r, const QString& projectDir,
             // data
         } else if (tag == Tag::Data) {
             m_dataItem.reset(readItemToEnd<DataItem>(r, this, tag));
-            dataError = m_dataItem->loadDatafield(projectDir, messageService);
+            dataError = m_dataItem->loadDatafield(messageService, projectDir);
             XML::gotoEndElementOfTag(r, tag);
 
             // native data
         } else if (tag == Tag::NativeData) {
             m_nativeDataItem.reset(readItemToEnd<DataItem>(r, this, tag));
-            nativeDataError == m_nativeDataItem->loadDatafield(projectDir, messageService);
+            nativeDataError == m_nativeDataItem->loadDatafield(messageService, projectDir);
             XML::gotoEndElementOfTag(r, tag);
 
             // native data units

GUI/Model/Job/JobItem.cpp

@@ -628,7 +628,7 @@ void JobItem::readFrom(QXmlStreamReader* r, const QString& projectDir,
             // simulated data
         } else if (tag == Tag::SimulatedData) {
             m_simulatedDataItem.reset(readItemToEnd<DataItem>(r, this, Tag::SimulatedData));
-            simError = m_simulatedDataItem->loadDatafield(projectDir, messageService);
+            simError = m_simulatedDataItem->loadDatafield(messageService, projectDir);
             XML::gotoEndElementOfTag(r, tag);
 
             // fit suite

GUI/Model/Project/IOService.cpp

@@ -82,7 +82,7 @@ void DatafieldIOService::loadDataFiles(const QString& projectDir, MessageService
     DatafieldDirHistory newHistory;
     for (SaveLoadInterface* item : dataInterfaces()) {
         try {
-            item->loadDatafield(projectDir, messageService);
+            item->loadDatafield(messageService, projectDir);
             newHistory.markAsSaved(item);
             // handling crash of GUI during job run and non-existing file
             if (auto* jobItem = parentJobItem(item)) {

GUI/Support/IO/SaveLoadInterface.h

@@ -29,7 +29,7 @@ public:
     virtual ~SaveLoadInterface() = default;
 
     //! Loads non-XML data from _projectDir_ and returns success flag.
-    virtual QString loadDatafield(const QString& projectDir, MessageService* messageService) = 0;
+    virtual QString loadDatafield(MessageService* messageService, const QString& projectDir = "") = 0;
 
     //! Saves non-XML data in _projectDir_ and returns success flag.
     virtual bool saveDatafield(const QString& projectDir) = 0;