PolFilter(Bloch_vector, mean_transmission)

Device/Pol/PolFilter.cpp

@@ -15,10 +15,11 @@
 #include "Device/Pol/PolFilter.h"
 #include "Base/Spin/SpinMatrix.h"
 #include "Base/Util/Assert.h"
+#include <iostream>
 
-PolFilter::PolFilter(R3 direction, double efficiency, double transmission)
-    : m_vecBloch(direction * efficiency)
-    , m_transmission(transmission)
+PolFilter::PolFilter(R3 Bloch_vector, double mean_transmission)
+    : m_vecBloch(Bloch_vector)
+    , m_transmission(mean_transmission)
 {
     if (m_transmission < 0 || m_transmission > 0.5)
         throw std::runtime_error("Invalid polarizer transmission");
@@ -26,9 +27,13 @@ PolFilter::PolFilter(R3 direction, double efficiency, double transmission)
         throw std::runtime_error("Invalid polarizer Bloch vector");
 }
 
-PolFilter::PolFilter()
-    : PolFilter({}, 0.0, 0.5)
+PolFilter::PolFilter(R3 direction, double efficiency, double transmission)
+    : PolFilter(direction * efficiency, transmission)
 {
+    std::cout
+        << "Constructor PolFilter(direction, efficiency, transmission) is obsolete since "
+           "BornAgain v21,\n"
+           "and will eventually be removed. Use PolFilter(Bloch_vector, transmission) instead.\n";
 }
 
 SpinMatrix PolFilter::matrix() const

Device/Pol/PolFilter.h

@@ -24,8 +24,8 @@ class SpinMatrix;
 
 class PolFilter : public INode {
 public:
-    PolFilter(R3 direction, double efficiency, double transmission);
-    PolFilter();
+    PolFilter(R3 direction, double efficiency, double transmission); // OBSOLETE since v21
+    PolFilter(R3 Bloch_vector = {}, double mean_transmission = 0.5);
     ~PolFilter() override = default;
 
     std::string className() const final { return "PolFilter"; }