Scale, Coord pass string and vector args the normal way (#963)

Base/Axis/Coordinate.cpp

@@ -38,9 +38,9 @@ std::pair<std::string, std::string> parse_label(const std::string& label)
 } // namespace
 
 
-Coordinate::Coordinate(std::string name, std::string unit)
-    : m_name(std::move(name))
-    , m_unit(std::move(unit))
+Coordinate::Coordinate(const std::string& name, const std::string& unit)
+    : m_name(name)
+    , m_unit(unit)
 {
 }
 

Base/Axis/Coordinate.h

@@ -26,7 +26,7 @@ public:
     {
     }
     Coordinate(const std::string& label);
-    Coordinate(std::string name, std::string unit);
+    Coordinate(const std::string& name, const std::string& unit);
 
     bool operator==(const Coordinate& other) const = default;
 

Base/Axis/Scale.cpp

@@ -24,8 +24,8 @@
 
 using std::numbers::pi;
 
-Scale::Scale(const Coordinate& coord, std::vector<Bin1D> bins)
-    : m_bins(std::move(bins))
+Scale::Scale(const Coordinate& coord, const std::vector<Bin1D>& bins)
+    : m_bins(bins)
     , m_coord(std::make_unique<Coordinate>(coord))
 {
     if (size() == 0)

Base/Axis/Scale.h

@@ -29,7 +29,7 @@ using trafo_t = std::function<double(double)>;
 
 class Scale {
 public:
-    Scale(const Coordinate& coord, std::vector<Bin1D> bins);
+    Scale(const Coordinate& coord, const std::vector<Bin1D>& bins);
     Scale(const Scale& other);
     Scale* clone() const;