rm/rename one-time setJob methods and signals

GUI/View/Main/CentralWidget.cpp

@@ -92,7 +92,7 @@ CentralWidget::CentralWidget()
     m_views_stack->insertWidget(ViewId::Simulation, m_simulation_view);
     m_views_stack->insertWidget(ViewId::Job, m_job_view);
 
-    connect(m_job_view, &JobView::jobSelected,
+    connect(m_job_view, &JobView::newJobActivated,
             [this]() { m_view_selection_buttons->button(ViewId::Job)->click(); });
     m_job_view->onJobSelectionChanged();
 }

GUI/View/View/JobView.cpp

@@ -75,7 +75,7 @@ JobView::JobView(QProgressBar* progressBar)
 
     // Focus request: JobsSet -> this
     connect(gDoc->jobs(), &JobsSet::jobMeritsAttention,
-            [this](JobItem* job_item) { onJobSelected(job_item); });
+            [this](JobItem* job_item) { switchToNewJob(job_item); });
 
     // JobItem selection: JobsPanel -> this
     connect(m_jobs_panel, &JobsPanel::selectedJobsChanged, this, &JobView::onJobSelectionChanged);
@@ -112,7 +112,7 @@ void JobView::fillViewMenu(QMenu* menu)
 
 void JobView::onJobSelectionChanged()
 {
-    setJob();
+    m_data_frames->showCurrentFrame();
     m_job_real_time_widget->setJobItem(selectedJobItem());
     m_fit_activity_panel->setJobItem(selectedJobItem());
 
@@ -125,7 +125,7 @@ void JobView::onJobSelectionChanged()
         setActivity(JobViewActivities::activityFromName(jobActivity));
 }
 
-void JobView::onJobSelected(JobItem* job_item)
+void JobView::switchToNewJob(JobItem* job_item)
 {
     ASSERT(job_item);
     if (!job_item->simulationOptionsItem()->runImmediately())
@@ -143,14 +143,9 @@ void JobView::onJobSelected(JobItem* job_item)
 
     setActivity(newActivity);
 
-    setJob();
-
-    emit jobSelected();
-}
-
-void JobView::setJob()
-{
     m_data_frames->showCurrentFrame();
+
+    emit newJobActivated();
 }
 
 

GUI/View/View/JobView.h

@@ -41,7 +41,7 @@ public:
     void fillViewMenu(QMenu* menu);
 
 signals:
-    void jobSelected();
+    void newJobActivated();
 
 public slots:
     void onJobSelectionChanged();
@@ -49,8 +49,7 @@ public slots:
 private:
     JobItem* selectedJobItem();
     void setActivity(JobViewActivity activity);
-    void setJob();
-    void onJobSelected(JobItem* job_item);
+    void switchToNewJob(JobItem* job_item);
 
     void resetLayout();