Skip to content
Snippets Groups Projects
Commit 80d9cd14 authored by Wuttke, Joachim's avatar Wuttke, Joachim
Browse files

ditto

parent d09048ee
No related branches found
No related tags found
1 merge request!451various little improvements as suggested by clang-tidy
Pipeline #49184 passed
...@@ -42,6 +42,7 @@ void report_error(MessageService* messageService, SessionItem* item, const QStri ...@@ -42,6 +42,7 @@ void report_error(MessageService* messageService, SessionItem* item, const QStri
SessionItem* createItem(SessionItem* item, const QString& modelType, const QString& tag) SessionItem* createItem(SessionItem* item, const QString& modelType, const QString& tag)
{ {
ASSERT(item);
if (item->hasModelType<GroupItem>()) { if (item->hasModelType<GroupItem>()) {
if (auto groupItem = dynamic_cast<GroupItem*>(item)) if (auto groupItem = dynamic_cast<GroupItem*>(item))
return groupItem->getItemOfType(modelType); return groupItem->getItemOfType(modelType);
...@@ -61,6 +62,8 @@ SessionItem* createItem(SessionItem* item, const QString& modelType, const QStri ...@@ -61,6 +62,8 @@ SessionItem* createItem(SessionItem* item, const QString& modelType, const QStri
void GUI::Session::XML::writeTo(QXmlStreamWriter* writer, SessionItem* parent) void GUI::Session::XML::writeTo(QXmlStreamWriter* writer, SessionItem* parent)
{ {
ASSERT(writer);
ASSERT(parent);
writer->writeStartElement(parent->model()->getModelTag()); writer->writeStartElement(parent->model()->getModelTag());
writer->writeAttribute(GUI::Session::XML::ModelNameAttribute, parent->model()->getModelName()); writer->writeAttribute(GUI::Session::XML::ModelNameAttribute, parent->model()->getModelName());
...@@ -71,6 +74,7 @@ void GUI::Session::XML::writeTo(QXmlStreamWriter* writer, SessionItem* parent) ...@@ -71,6 +74,7 @@ void GUI::Session::XML::writeTo(QXmlStreamWriter* writer, SessionItem* parent)
void GUI::Session::XML::writeItemAndChildItems(QXmlStreamWriter* writer, const SessionItem* item) void GUI::Session::XML::writeItemAndChildItems(QXmlStreamWriter* writer, const SessionItem* item)
{ {
ASSERT(item);
if (item->parent()) { if (item->parent()) {
writer->writeStartElement(GUI::Session::XML::ItemTag); writer->writeStartElement(GUI::Session::XML::ItemTag);
writer->writeAttribute(GUI::Session::XML::ModelTypeAttribute, item->modelType()); writer->writeAttribute(GUI::Session::XML::ModelTypeAttribute, item->modelType());
...@@ -101,6 +105,7 @@ void GUI::Session::XML::writeItemAndChildItems(QXmlStreamWriter* writer, const S ...@@ -101,6 +105,7 @@ void GUI::Session::XML::writeItemAndChildItems(QXmlStreamWriter* writer, const S
void GUI::Session::XML::writeVariant(QXmlStreamWriter* writer, QVariant variant, int role) void GUI::Session::XML::writeVariant(QXmlStreamWriter* writer, QVariant variant, int role)
{ {
ASSERT(writer);
if (variant.isValid()) { if (variant.isValid()) {
writer->writeStartElement(GUI::Session::XML::ParameterTag); writer->writeStartElement(GUI::Session::XML::ParameterTag);
QString type_name = variant.typeName(); QString type_name = variant.typeName();
...@@ -144,6 +149,7 @@ void GUI::Session::XML::readItems(QXmlStreamReader* reader, SessionItem* parent, ...@@ -144,6 +149,7 @@ void GUI::Session::XML::readItems(QXmlStreamReader* reader, SessionItem* parent,
MessageService* messageService) MessageService* messageService)
{ {
bool legacyDistributionFound = false; bool legacyDistributionFound = false;
ASSERT(reader);
ASSERT(parent); ASSERT(parent);
const QString start_type = parent->model()->getModelTag(); const QString start_type = parent->model()->getModelTag();
while (!reader->atEnd()) { while (!reader->atEnd()) {
...@@ -213,6 +219,7 @@ void GUI::Session::XML::readItems(QXmlStreamReader* reader, SessionItem* parent, ...@@ -213,6 +219,7 @@ void GUI::Session::XML::readItems(QXmlStreamReader* reader, SessionItem* parent,
QString GUI::Session::XML::readProperty(QXmlStreamReader* reader, SessionItem* item, QString GUI::Session::XML::readProperty(QXmlStreamReader* reader, SessionItem* item,
MessageService* messageService) MessageService* messageService)
{ {
ASSERT(reader);
const QString parameter_name = const QString parameter_name =
reader->attributes().value(GUI::Session::XML::ParameterNameAttribute).toString(); reader->attributes().value(GUI::Session::XML::ParameterNameAttribute).toString();
const QString parameter_type = const QString parameter_type =
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment