Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
BornAgain
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
mlz
BornAgain
Commits
775cd276
Commit
775cd276
authored
3 years ago
by
t.knopff
Browse files
Options
Downloads
Patches
Plain Diff
Make JobItem::P_COMMENTS private
parent
43aa454a
No related branches found
No related tags found
1 merge request
!99
Refactor model: JobItem
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
GUI/Models/JobItem.cpp
+5
-0
5 additions, 0 deletions
GUI/Models/JobItem.cpp
GUI/Models/JobItem.h
+3
-1
3 additions, 1 deletion
GUI/Models/JobItem.h
GUI/Views/JobWidgets/JobPropertiesWidget.cpp
+1
-1
1 addition, 1 deletion
GUI/Views/JobWidgets/JobPropertiesWidget.cpp
with
9 additions
and
2 deletions
GUI/Models/JobItem.cpp
+
5
−
0
View file @
775cd276
...
@@ -283,6 +283,11 @@ bool JobItem::isStatusPropertyName(const QString& name)
...
@@ -283,6 +283,11 @@ bool JobItem::isStatusPropertyName(const QString& name)
return
name
==
P_STATUS
;
return
name
==
P_STATUS
;
}
}
bool
JobItem
::
isCommentsPropertyName
(
const
QString
&
name
)
{
return
name
==
P_COMMENTS
;
}
//! Updates the name of file to store intensity data.
//! Updates the name of file to store intensity data.
void
JobItem
::
updateIntensityDataFileName
()
void
JobItem
::
updateIntensityDataFileName
()
...
...
This diff is collapsed.
Click to expand it.
GUI/Models/JobItem.h
+
3
−
1
View file @
775cd276
...
@@ -41,9 +41,9 @@ private:
...
@@ -41,9 +41,9 @@ private:
static
const
QString
P_BEGIN_TIME
;
static
const
QString
P_BEGIN_TIME
;
static
const
QString
P_END_TIME
;
static
const
QString
P_END_TIME
;
static
const
QString
P_DURATION
;
static
const
QString
P_DURATION
;
static
const
QString
P_COMMENTS
;
public:
public:
static
const
QString
P_COMMENTS
;
static
const
QString
P_PROGRESS
;
static
const
QString
P_PROGRESS
;
static
const
QString
P_PRESENTATION_TYPE
;
static
const
QString
P_PRESENTATION_TYPE
;
static
const
QString
T_SAMPLE
;
static
const
QString
T_SAMPLE
;
...
@@ -114,6 +114,8 @@ public:
...
@@ -114,6 +114,8 @@ public:
static
bool
isStatusPropertyName
(
const
QString
&
name
);
static
bool
isStatusPropertyName
(
const
QString
&
name
);
static
bool
isCommentsPropertyName
(
const
QString
&
name
);
private:
private:
void
updateIntensityDataFileName
();
void
updateIntensityDataFileName
();
const
SimulationOptionsItem
*
simulationOptionsItem
()
const
;
const
SimulationOptionsItem
*
simulationOptionsItem
()
const
;
...
...
This diff is collapsed.
Click to expand it.
GUI/Views/JobWidgets/JobPropertiesWidget.cpp
+
1
−
1
View file @
775cd276
...
@@ -61,7 +61,7 @@ void JobPropertiesWidget::subscribeToItem()
...
@@ -61,7 +61,7 @@ void JobPropertiesWidget::subscribeToItem()
{
{
currentItem
()
->
mapper
()
->
setOnPropertyChange
(
currentItem
()
->
mapper
()
->
setOnPropertyChange
(
[
this
](
const
QString
&
name
)
{
[
this
](
const
QString
&
name
)
{
if
(
name
==
JobItem
::
P_COMMENTS
)
if
(
JobItem
::
isCommentsPropertyName
(
name
)
)
updateItem
();
updateItem
();
},
},
this
);
this
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment