[j.3] ensure that there are no duplicate names in lists; disable cp/rm actions for empty lists ()

Merging branch 'j.3'  into 'main'.

See merge request !2404

GUI/Model/Type/NamedItem.cpp

+//  ************************************************************************************************
+//
+//  BornAgain: simulate and fit reflection and scattering
+//
+//! @file      GUI/Model/Type/NamedItem.cpp
+//! @brief     Implements class NamedItem.
+//!
+//! @homepage  http://www.bornagainproject.org
+//! @license   GNU General Public License v3 or higher (see COPYING)
+//! @copyright Forschungszentrum Jülich GmbH 2021
+//! @authors   Scientific Computing Group at MLZ (see CITATION, AUTHORS)
+//
+//  ************************************************************************************************
+
+#include "GUI/Model/Type/NamedItem.h"
+#include <QRegularExpression>
+#include <QRegularExpressionMatch>
+
+namespace {
+
+QStringList splitName(const QString& s)
+{
+    QRegularExpression pattern("(.*)_(\\d+)$");
+    QRegularExpressionMatch match = pattern.match(s);
+    if (match.hasMatch()) {
+        QStringList groups;
+        for (int i = 1; i < match.lastCapturedIndex() + 1; ++i)
+            groups << match.captured(i);
+        return groups;
+    }
+    return {}; // s does not contain '_\d+'
+}
+
+} // namespace
+
+
+void NamedItem::renumber(const QStringList& extant_names)
+{
+    // Item name consists of a stem and an optional number
+    QStringList ns = ::splitName(name());
+    QString stem = ns.isEmpty() ? name() : ns[0];
+
+    // Determine highest number for given stem in extant_items
+    int imax = 0;
+    for (QString tname : extant_names) {
+        QStringList ts = ::splitName(tname);
+        if (ts.isEmpty()) {
+            if (tname == stem)
+                imax = std::max(imax, 1);
+        } else {
+            if (ts[0] == stem)
+                imax = std::max(imax, ts[1].toInt());
+        }
+    }
+
+    if (imax != 0)
+        setName(stem + "_" + QString::number(imax + 1));
+
+    if (name().contains(' '))
+        setName(name().replace(' ', '_'));
+}

GUI/Model/Type/NamedItem.h

@@ -3,7 +3,7 @@
 //  BornAgain: simulate and fit reflection and scattering
 //
 //! @file      GUI/Model/Type/NamedItem.h
-//! @brief     Defines and implements class NamedItem.
+//! @brief     Defines class NamedItem.
 //!
 //! @homepage  http://www.bornagainproject.org
 //! @license   GNU General Public License v3 or higher (see COPYING)
@@ -16,6 +16,7 @@
 #define BORNAGAIN_GUI_MODEL_TYPE_NAMEDITEM_H
 
 #include <QString>
+#include <vector>
 
 //! Base class of items that have a name and a description.
 
@@ -33,6 +34,10 @@ public:
     QString description() const { return m_description; }
     void setDescription(const QString& description) { m_description = description; }
 
+    //! Changes name of item to avoid duplication of any name from extant items.
+    //! Also replaces blank by underscore characters.
+    void renumber(const QStringList& extant_names);
+
 private:
     QString m_name;
     QString m_description;

GUI/Model/Type/SetWithModel.h

@@ -74,6 +74,7 @@ public:
     void add_item(T* t)
     {
         m_qmodel->beginInsertRows({}, size(), size());
+        t->renumber(itemNames());
         m_vec.push_back(t);
         m_idx = m_vec.size() - 1;
         m_qmodel->endInsertRows();
@@ -82,8 +83,10 @@ public:
     void add_items(std::vector<T*> v)
     {
         m_qmodel->beginInsertRows({}, size(), size());
-        for (T* t : v)
+        for (T* t : v) {
+            t->renumber(itemNames());
             m_vec.push_back(t);
+        }
         m_idx = m_vec.size() - 1;
         m_qmodel->endInsertRows();
         emit AbstractSetModel::setChanged();

GUI/View/List/DatafilesSelector.cpp

@@ -56,6 +56,7 @@ DatafilesSelector::DatafilesSelector()
     splitter->addWidget(m_editor);
     splitter->setChildrenCollapsible(true);
 
+    connect(m_set, &AbstractSetModel::setChanged, this, &DatafilesSelector::updateActions);
     updateActions();
 }
 

GUI/View/Views/InstrumentView.cpp

@@ -154,7 +154,12 @@ void InstrumentView::createWidgetsForCurrentInstrument()
     layout->addWidget(g);
 
     auto* nameEdit = new QLineEdit(t->name(), g);
-    connect(nameEdit, &QLineEdit::textEdited, [t](const QString& text) { t->setName(text); });
+    connect(nameEdit, &QLineEdit::textEdited, [this, t](const QString& text) {
+        if (text != t->name()) {
+            t->setName(text);
+            emit m_set->setChanged();
+        }
+    });
     formLayout->addRow("Name:", nameEdit);
 
     auto* descriptionEdit = new QTextEdit(g);
@@ -163,8 +168,10 @@ void InstrumentView::createWidgetsForCurrentInstrument()
     descriptionEdit->setAcceptRichText(false);
     descriptionEdit->setTabChangesFocus(true);
     descriptionEdit->setPlainText(t->description());
-    connect(descriptionEdit, &QTextEdit::textChanged,
-            [t, descriptionEdit] { t->setDescription(descriptionEdit->toPlainText()); });
+    connect(descriptionEdit, &QTextEdit::textChanged, [this, t, descriptionEdit] {
+        t->setDescription(descriptionEdit->toPlainText());
+        emit m_set->setChanged();
+    });
     formLayout->addRow("Description:", descriptionEdit);
 
     //... All remaining content depends on instrument type

GUI/View/Views/SampleView.cpp

@@ -97,6 +97,7 @@ SampleView::SampleView()
         editor->setCurrentSample(t);
         onRequestViewInRealspace(t);
         scriptPanel->setCurrentSample(t);
+        updateActions();
     });
 
     connect(editor, &SampleEditor::modified, scriptPanel, &ScriptPanel::onSampleModified);
@@ -110,6 +111,8 @@ SampleView::SampleView()
             &RealspaceWidget::updateScene);
 
     connect(editor, &SampleEditor::modified, gDoc.get(), &ProjectDocument::setModified);
+
+    updateActions();
 }
 
 SampleView::~SampleView()
@@ -180,6 +183,13 @@ void SampleView::setToolbarActions(QToolBar* toolbar)
     connect(m_rm_action, &QAction::triggered, m_set, &SamplesSet::delete_current);
 }
 
+void SampleView::updateActions()
+{
+    bool enabled = m_set->currentIndex() != size_t(-1);
+    m_rm_action->setEnabled(enabled);
+    m_cp_action->setEnabled(enabled);
+}
+
 void SampleView::applySplitterPos()
 {
     QSettings settings;