Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
BornAgain
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
mlz
BornAgain
Commits
73f31bb2
Commit
73f31bb2
authored
1 year ago
by
Wuttke, Joachim
Browse files
Options
Downloads
Patches
Plain Diff
SamplesQModel use gDoc directly, rm member pointer
parent
b265ff3a
No related branches found
No related tags found
1 merge request
!2360
simplify and unify samples & instruments list code
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
GUI/View/List/SamplesQModel.cpp
+14
-19
14 additions, 19 deletions
GUI/View/List/SamplesQModel.cpp
GUI/View/List/SamplesQModel.h
+0
-6
0 additions, 6 deletions
GUI/View/List/SamplesQModel.h
with
14 additions
and
25 deletions
GUI/View/List/SamplesQModel.cpp
+
14
−
19
View file @
73f31bb2
...
...
@@ -23,17 +23,12 @@
#include
"GUI/View/Manager/PyImportAssistant.h"
#include
"Sample/Multilayer/MultiLayer.h"
SamplesQModel
::
SamplesQModel
()
:
m_sample_items
(
gDoc
->
samplesModifier
())
{
}
int
SamplesQModel
::
rowCount
(
const
QModelIndex
&
parent
)
const
{
if
(
parent
.
isValid
())
return
0
;
return
m_sample_items
->
sampleItems
().
size
();
return
gDoc
->
samples
()
->
sampleItems
().
size
();
}
QVariant
SamplesQModel
::
data
(
const
QModelIndex
&
index
,
int
role
)
const
...
...
@@ -82,12 +77,12 @@ SampleItem* SamplesQModel::itemForIndex(const QModelIndex& index) const
if
(
!
index
.
isValid
())
return
nullptr
;
return
m_sample_items
->
sampleItems
()[
index
.
row
()];
return
gDoc
->
samples
()
->
sampleItems
()[
index
.
row
()];
}
QModelIndex
SamplesQModel
::
indexForItem
(
SampleItem
*
item
)
const
{
if
(
auto
row
=
m_sample_items
->
sampleItems
().
indexOf
(
item
);
row
>=
0
)
if
(
auto
row
=
gDoc
->
samples
()
->
sampleItems
().
indexOf
(
item
);
row
>=
0
)
return
index
(
row
,
0
);
return
{};
...
...
@@ -100,31 +95,31 @@ void SamplesQModel::removeSample(SampleItem* item)
return
;
beginRemoveRows
(
index
.
parent
(),
index
.
row
(),
index
.
row
());
m_sample_items
->
removeSample
(
item
);
gDoc
->
samplesModifier
()
->
removeSample
(
item
);
endRemoveRows
();
}
QModelIndex
SamplesQModel
::
copySample
(
SampleItem
*
item
)
{
ASSERT
(
item
);
const
QStringList
existingNames
=
m_sample_items
->
sampleNames
();
const
QStringList
existingNames
=
gDoc
->
samples
()
->
sampleNames
();
const
int
row
=
m_sample_items
->
sampleItems
().
size
();
const
int
row
=
gDoc
->
samples
()
->
sampleItems
().
size
();
beginInsertRows
(
QModelIndex
(),
row
,
row
);
SampleItem
*
copied_item
=
item
->
clone
();
copied_item
->
setSampleName
(
GUI
::
Util
::
String
::
suggestName
(
existingNames
,
item
->
sampleName
()));
m_sample_items
->
addSampleItem
(
copied_item
);
gDoc
->
samplesModifier
()
->
addSampleItem
(
copied_item
);
endInsertRows
();
return
indexForItem
(
copied_item
);
}
QModelIndex
SamplesQModel
::
createSample
()
{
const
QStringList
existingNames
=
m_sample_items
->
sampleNames
();
const
QStringList
existingNames
=
gDoc
->
samples
()
->
sampleNames
();
const
int
row
=
m_sample_items
->
sampleItems
().
size
();
const
int
row
=
gDoc
->
samples
()
->
sampleItems
().
size
();
beginInsertRows
(
QModelIndex
(),
row
,
row
);
auto
*
sample_item
=
m_sample_items
->
addSampleItem
();
auto
*
sample_item
=
gDoc
->
samplesModifier
()
->
addSampleItem
();
sample_item
->
setSampleName
(
GUI
::
Util
::
String
::
suggestName
(
existingNames
,
"Sample"
));
sample_item
->
addStandardMaterials
();
endInsertRows
();
...
...
@@ -140,9 +135,9 @@ QModelIndex SamplesQModel::createSampleFromExamples(const QString& className, co
sample
->
setSampleName
(
title
);
sample
->
setDescription
(
description
);
const
int
row
=
m_sample_items
->
sampleItems
().
size
();
const
int
row
=
gDoc
->
samples
()
->
sampleItems
().
size
();
beginInsertRows
(
QModelIndex
(),
row
,
row
);
m_sample_items
->
addSampleItem
(
sample
);
gDoc
->
samplesModifier
()
->
addSampleItem
(
sample
);
endInsertRows
();
return
indexForItem
(
sample
);
}
...
...
@@ -160,9 +155,9 @@ QModelIndex SamplesQModel::createSampleFromPython()
sampleItem
->
setDescription
(
"Imported from python code"
);
const
int
row
=
m_sample_items
->
sampleItems
().
size
();
const
int
row
=
gDoc
->
samples
()
->
sampleItems
().
size
();
beginInsertRows
(
QModelIndex
(),
row
,
row
);
m_sample_items
->
addSampleItem
(
sampleItem
);
gDoc
->
samplesModifier
()
->
addSampleItem
(
sampleItem
);
endInsertRows
();
return
indexForItem
(
sampleItem
);
}
...
...
This diff is collapsed.
Click to expand it.
GUI/View/List/SamplesQModel.h
+
0
−
6
View file @
73f31bb2
...
...
@@ -18,14 +18,11 @@
#include
<QAbstractItemModel>
class
SampleItem
;
class
SamplesSet
;
//! List model for sample selection (used in the left pane of SampleView)
class
SamplesQModel
:
public
QAbstractListModel
{
Q_OBJECT
public:
SamplesQModel
();
int
rowCount
(
const
QModelIndex
&
parent
=
QModelIndex
())
const
override
;
QVariant
data
(
const
QModelIndex
&
index
,
int
role
=
Qt
::
DisplayRole
)
const
override
;
Qt
::
ItemFlags
flags
(
const
QModelIndex
&
index
)
const
override
;
...
...
@@ -55,9 +52,6 @@ public:
//! Returns invalid index if anything went wrong.
QModelIndex
createSampleFromPython
();
#endif
private:
SamplesSet
*
m_sample_items
=
nullptr
;
};
#endif // BORNAGAIN_GUI_VIEW_LIST_SAMPLESQMODEL_H
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment