ready to tidy readability-simplify-boolean-expr

.clang-tidy

@@ -15,145 +15,23 @@
 Checks: '*,
 
 
--SectionComment_We_disagree_with_the_following_checks__They_shall_remain_permanently_disabled,
-
--*-braces-around-statements,
--*-convert-member-functions-to-static,
--*-implicit-bool-conversion,
--*-magic-numbers,
--*-named-parameter,
--*-trailing-return*,
--*-uppercase-literal-suffix,
--*nodiscard,
--abseil-*,
--altera-struct-pack-align,
--altera-unroll-loops,
--bugprone-branch-clone,
--bugprone-easily-swappable-parameters,
--bugprone-implicit-widening-of-multiplication-result,
--bugprone-suspicious-include,
--cert-err58-cpp,
--cert-err61-cpp,
--cert-msc30-c*,
--cert-msc32-c,
--cert-msc50-cpp,
--cert-msc51-cpp,
--clang-analyzer-alpha*,
--clang-analyzer-alpha.deadcode.UnreachableCode,
--clang-analyzer-security.insecureAPI.strcpy,
--cppcoreguidelines-init-variables,
--cppcoreguidelines-macro-usage,
--cppcoreguidelines-non-private-member-variables-in-classes,
--cppcoreguidelines-pro-bounds-constant-array-index,
--cppcoreguidelines-pro-bounds-pointer-arithmetic,
--cppcoreguidelines-pro-type-cstyle-cast,
--cppcoreguidelines-pro-type-member-init,
--cppcoreguidelines-pro-type-reinterpret-cast,
--cppcoreguidelines-pro-type-vararg,
--cppcoreguidelines-slicing,
--fuchsia-default-arguments-calls,
--fuchsia-default-arguments-declarations,
--fuchsia-overloaded-operator,
--fuchsia-statically-constructed-objects,
--fuchsia-trailing-return,
--google-build-using-namespace,
--google-default-arguments,
--google-explicit-constructor,
--google-readability-avoid-underscore-in-googletest-name,
--google-readability-casting,
--google-readability-todo,
--google-runtime-int,
--hicpp-exception-baseclass,
--hicpp-explicit-conversions,
--hicpp-member-init,
--hicpp-noexcept-move,
--hicpp-signed-bitwise,
--hicpp-vararg,
--llvmlibc-callee-namespace,
--llvmlibc-implementation-in-namespace,
--llvmlibc-restrict-system-libc-headers,
--misc-no-recursion,
--misc-throw-by-value-catch-by-reference,
--performance-faster-string-find,
--performance-inefficient-string-concatenation,
--performance-noexcept-move-constructor,
--performance-no-automatic-move,
--performance-unnecessary-value-param,
--readability-identifier-length,
--readability-misleading-indentation,
--readability-use-anyofallof,
-
--SectionComment_To_be_manually_checked_from_time_to_time,
-
--readability-isolate-declaration,
--performance-inefficient-vector-operation,
--performance-unnecessary-copy-initialization,
--*-move-const-arg,
--modernize-use-default-member-init,
--readability-redundant-member-init,
-
-
--SectionComment_Disabled_unless_3rdparty_libraries_are_improved,
-
--*avoid-goto,
--*special-member-functions,
--clang-analyzer-cplusplus.NewDeleteLeaks,
--cppcoreguidelines-avoid-non-const-global-variables,
--cppcoreguidelines-pro-bounds-array-to-pointer-decay,
--hicpp-no-array-decay,
--llvm-include-order,
--llvm-namespace-comment,
--readability-redundant-access-specifiers,
-
-
--SectionComment_Resolving_the_following_checks_would_be_too_much_work_right_now,
-
--*avoid-c-arrays,
--*narrowing-conversions,
--cppcoreguidelines-prefer-member-initializer,
--cppcoreguidelines-owning-memory,
--bugprone-unused-return-value,
--bugprone-parent-virtual-call,
-
-
--SectionComment_Temporarily_disabled_checks__We_need_to_investigate_them_one_by_one,
-
--altera-id-dependent-backward-branch,
--bugprone-copy-constructor-init,
--bugprone-exception-escape,
--bugprone-misplaced-widening-cast,
--clang-analyzer-core.CallAndMessage,
--clang-analyzer-optin.cplusplus.VirtualCall,
--cppcoreguidelines-pro-type-const-cast,
--cppcoreguidelines-pro-type-static-cast-downcast,
--google-runtime-references,
--misc-non-private-member-variables-in-classes,
--modernize-loop-convert,
--readability-function-cognitive-complexity,
-
--SectionComment_Automizable__To_be_kept_satisfied,
-*-use-auto,
-*-use-emplace,
-*-use-equals-default,
-*-use-nullptr,
-*-use-override,
-cppcoreguidelines-explicit-virtual-functions,
-google-readability-avoid-underscore-in-googletest-name,
-llvm-qualified-auto,
-misc-uniqueptr-reset-release,
-modernize-avoid-bind,
-modernize-make-unique,
-modernize-pass-by-value,
-modernize-raw-string-literal,
-modernize-use-using,
-performance-for-range-copy,
-readability-avoid-const-params-in-decls,
-readability-const-return-type,
-readability-non-const-parameter,
-readability-container-size-empty,
-readability-delete-null-pointer,
-readability-inconsistent-declaration-parameter-name,
-readability-qualified-auto,
+-*,
+-cppcoreguidelines-explicit-virtual-functions,
+-llvm-qualified-auto,
+-misc-uniqueptr-reset-release,
+-modernize-avoid-bind,
+-modernize-make-unique,
+-modernize-pass-by-value,
+-modernize-raw-string-literal,
+-modernize-use-using,
+-performance-for-range-copy,
+-readability-avoid-const-params-in-decls,
+-readability-const-return-type,
+-readability-non-const-parameter,
+-readability-container-size-empty,
+-readability-delete-null-pointer,
+-readability-inconsistent-declaration-parameter-name,
+-readability-qualified-auto,
 readability-simplify-boolean-expr,
 
 

CMakeLists.txt

@@ -234,7 +234,7 @@ endif()
 
 # from here on our own code, occasionally scrutinized by clang-tidy
 if(BA_TIDY)
-    set(CMAKE_CXX_CLANG_TIDY "clang-tidy") # has effect only if compiler is clang; uses .clang-tidy
+    set(CMAKE_CXX_CLANG_TIDY "clang-tidy;--fix") # has effect only if compiler is clang; uses .clang-tidy
 endif()
 
 # configure core component libraries