WidgetUtils are unified

GUI/View/Common/DoubleSpinBox.cpp

@@ -16,9 +16,10 @@
 #include "GUI/View/Tool/EditUtil.h"
 #include <QWheelEvent>
 
-DoubleSpinBox::DoubleSpinBox(QWidget* parent, const DoubleDescriptor& d)
+DoubleSpinBox::DoubleSpinBox(const DoubleDescriptor& d, bool easyScrollable, QWidget* parent)
     : QDoubleSpinBox(parent)
     , m_valueDescriptor(d)
+    , easyScrollable(easyScrollable)
 {
     setFocusPolicy(Qt::StrongFocus);
     GUI::View::EditUtil::configSpinbox(this, d.decimals, d.limits);
@@ -80,10 +81,10 @@ void DoubleSpinBox::setBaseValue(double baseValue)
 
 void DoubleSpinBox::wheelEvent(QWheelEvent* event)
 {
-    if (!hasFocus())
-        event->ignore();
-    else
+    if (hasFocus() || easyScrollable)
         QDoubleSpinBox::wheelEvent(event);
+    else
+        event->ignore();
 }
 
 void DoubleSpinBox::onDisplayValueChanged(double newDisplayValue)

GUI/View/Common/DoubleSpinBox.h

@@ -28,7 +28,7 @@ public:
     //! Furthermore, the spin box will prohibit accidental changes by the mouse wheel. Otherwise it
     //! would be dangerous if the spin box is on a scrollable form - unintended and unnoticed
     //! changes would take place when just scrolling through the form.
-    DoubleSpinBox(QWidget* parent, const DoubleDescriptor& d);
+    DoubleSpinBox(const DoubleDescriptor& d, bool easyScrollable = false, QWidget* parent = nullptr);
 
     //! Set a display unit.
     //!
@@ -77,6 +77,7 @@ private:
     Unit m_displayUnit = Unit::unitless;
 
     DoubleDescriptor m_valueDescriptor;
+    bool easyScrollable;
 
     //! it was decided to not show the unit as a suffix. However, this may be user
     //! selectable once, therefore the code is kept and controlled by this flag

GUI/View/Fit/MinimizerSettingsWidget.cpp

@@ -17,6 +17,7 @@
 #include "GUI/Model/Job/JobItem.h"
 #include "GUI/Model/Job/MinimizerItem.h"
 #include "GUI/View/Common/DoubleSpinBox.h"
+#include "GUI/View/Common/SafeSpinBox.h"
 #include "GUI/View/Tool/LayoutUtils.h"
 #include "GUI/View/Tool/WidgetUtils.h"
 #include <QComboBox>
@@ -55,7 +56,7 @@ void MinimizerSettingsWidget::setItem(MinimizerContainerItem* minimizerItem)
         return;
 
     m_mainLayout->addRow("Minimizer:",
-                         GUI::Util::createComboBox(m_currentItem->minimizers(), &m_updaters,
+                         GUI::Util::createComboBoxUpdScroll(m_currentItem->minimizers(), &m_updaters,
                          [=](int) { createMimimizerEdits(); }));
 
     auto* w = new QWidget(this);
@@ -64,39 +65,14 @@ void MinimizerSettingsWidget::setItem(MinimizerContainerItem* minimizerItem)
     m_mainLayout->addRow(w);
 
     m_mainLayout->addRow("Objective metric:",
-                         GUI::Util::createComboBox(m_currentItem->objectiveMetric(), &m_updaters));
+                         GUI::Util::createComboBoxUpdScroll(m_currentItem->objectiveMetric(), &m_updaters));
     m_mainLayout->addRow("Norm function:",
-                         GUI::Util::createComboBox(m_currentItem->normFunction(), &m_updaters));
+                         GUI::Util::createComboBoxUpdScroll(m_currentItem->normFunction(), &m_updaters));
 
     createMimimizerEdits();
     updateUIValues();
 }
 
-QWidget* MinimizerSettingsWidget::createSpinbox(UIntDescriptor d)
-{
-    auto* spinBox = new QSpinBox(this);
-    spinBox->setToolTip(d.tooltip);
-    spinBox->setMaximum(std::numeric_limits<int>::max());
-    spinBox->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
-
-    if (d.limits.hasLowerLimit())
-        spinBox->setMinimum(static_cast<int>(d.limits.lowerLimit()));
-    if (d.limits.hasUpperLimit())
-        spinBox->setMaximum(static_cast<int>(d.limits.upperLimit()));
-
-    spinBox->setValue(d.get());
-
-    QObject::connect(spinBox, QOverload<int>::of(&QSpinBox::valueChanged),
-                     [=](int newValue) { d.set(newValue); });
-
-    m_updaters << [=]() {
-        QSignalBlocker b(spinBox);
-        spinBox->setValue(d.get());
-    };
-
-    return spinBox;
-}
-
 void MinimizerSettingsWidget::createMimimizerEdits()
 {
     GUI::Util::Layout::clearLayout(m_minimizerLayout);
@@ -107,10 +83,10 @@ void MinimizerSettingsWidget::createMimimizerEdits()
             m_minimizerLayout->addRow(d.label + ":", GUI::Util::createDoubleSpinbox(d, &m_updaters));
         } else if (std::holds_alternative<SelectionDescriptor<QString>>(v)) {
             auto d = std::get<SelectionDescriptor<QString>>(v);
-            m_minimizerLayout->addRow(d.label + ":", GUI::Util::createComboBox(d, &m_updaters));
+            m_minimizerLayout->addRow(d.label + ":", GUI::Util::createComboBoxUpdScroll(d, &m_updaters));
         } else if (std::holds_alternative<UIntDescriptor>(v)) {
             auto d = std::get<UIntDescriptor>(v);
-            m_minimizerLayout->addRow(d.label + ":", createSpinbox(d));
+            m_minimizerLayout->addRow(d.label + ":", GUI::Util::createSpinBoxScroll(d, &m_updaters));
         }
     }
 }

GUI/View/Fit/MinimizerSettingsWidget.h

@@ -42,7 +42,6 @@ public slots:
     void setItem(MinimizerContainerItem* minimizerItem);
 
 private:
-    QWidget* createSpinbox(UIntDescriptor d);
     void createMimimizerEdits();
 
     void updateUIValues();

GUI/View/Instrument/DetectorAlignmentEditor.cpp

@@ -53,7 +53,7 @@ DetectorAlignmentEditor::DetectorAlignmentEditor(QWidget* parent, RectangularDet
     auto* m_combo = GUI::Util::createComboBox(item->detectorAlignmentSelection(), [=](int) {
             createAligmentWidgets();
             emit dataChanged();
-        }, false);
+        });
 
     m_formLayout->addRow("Alignment:", m_combo);
 
@@ -73,9 +73,9 @@ DoubleSpinBox* DetectorAlignmentEditor::createSpinBox(QFormLayout* parentFormLay
     return sb;
 }
 
-DoubleSpinBox* DetectorAlignmentEditor::createSpinBox(QWidget* parent, const DoubleDescriptor& d)
+DoubleSpinBox* DetectorAlignmentEditor::createSpinBox(const DoubleDescriptor& d)
 {
-    auto* sb = new DoubleSpinBox(parent, d);
+    auto* sb = new DoubleSpinBox(d);
     connect(sb, &DoubleSpinBox::baseValueChanged, [=](double v) {
         if (d.get() != v) {
             d.set(v);
@@ -91,7 +91,7 @@ void DetectorAlignmentEditor::addVector(QFormLayout* parentLayout, const VectorD
 
     const auto add = [&](const DoubleDescriptor& d) {
         layout->addWidget(new QLabel(GUI::Util::labelWithUnit(d) + ":"));
-        layout->addWidget(createSpinBox(parentLayout->parentWidget(), d));
+        layout->addWidget(createSpinBox(d));
     };
 
     add(d.x);

GUI/View/Instrument/DetectorAlignmentEditor.h

@@ -38,7 +38,7 @@ signals:
 private:
     void createAligmentWidgets();
     DoubleSpinBox* createSpinBox(QFormLayout* parentFormLayout, const DoubleDescriptor& d);
-    DoubleSpinBox* createSpinBox(QWidget* parent, const DoubleDescriptor& d);
+    DoubleSpinBox* createSpinBox(const DoubleDescriptor& d);
     void addVector(QFormLayout* parentLayout, const VectorDescriptor& d);
 
 private:

GUI/View/Instrument/DetectorEditor.cpp

@@ -33,7 +33,7 @@ DetectorEditor::DetectorEditor(QWidget* parent, Instrument2DItem* instrument)
     auto* detectorTypeCombo = GUI::Util::createComboBox(instrument->detectorSelection(), [=](int) {
             createDetectorWidgets();
             emit dataChanged();
-        }, false);
+        });
     m_formLayout->addRow("Detector:", detectorTypeCombo);
 
     GroupBoxCollapser::installIntoGroupBox(this);

GUI/View/Instrument/DistributionEditor.cpp

@@ -48,7 +48,7 @@ DistributionSelector::DistributionSelector(std::optional<MeanConfig> mean_config
     m_distributionCombo = GUI::Util::createComboBox(item->distributionSelection(), [=](int) {
             createDistributionWidgets();
             emit distributionChanged();
-        }, false);
+        });
     m_formLayout->addRow("Distribution:", m_distributionCombo);
 
     createDistributionWidgets();

GUI/View/Instrument/EnvironmentEditor.cpp

@@ -32,7 +32,7 @@ EnvironmentEditor::EnvironmentEditor(QWidget* parent, InstrumentItem* instrument
             GUI::Util::createComboBox(instrument->backgroundSelection(), [=](int) {
             createBackgroundWidgets();
             emit dataChanged();
-        }, false);
+        });
     m_formLayout->addRow("Background type:", backgroundTypeCombo);
 
     createBackgroundWidgets();
@@ -46,7 +46,7 @@ void EnvironmentEditor::createBackgroundWidgets()
 
     auto* backgroundItem = m_instrument->backgroundSelection().currentItem();
     if (auto* p = dynamic_cast<ConstantBackgroundItem*>(backgroundItem)) {
-        auto* spinbox = new DoubleSpinBox(this, p->backgroundValue());
+        auto* spinbox = new DoubleSpinBox(p->backgroundValue());
         spinbox->setSingleStep(0.01);
         m_formLayout->addRow("Background value:", spinbox);
 

GUI/View/Instrument/FootprintCorrectionEditor.cpp

@@ -31,7 +31,7 @@ FootprintCorrectionEditor::FootprintCorrectionEditor(QWidget* parent, SpecularBe
     auto* typeCombo = GUI::Util::createComboBox(item->footprintSelection(), [=](int) {
         createFootprintWidgets();
         emit dataChanged();
-    }, false);
+    });
     m_formLayout->addRow("Type:", typeCombo);
 
     GroupBoxCollapser::installIntoGroupBox(this);
@@ -46,7 +46,7 @@ void FootprintCorrectionEditor::createFootprintWidgets()
 
     auto* footprintItem = m_item->footprintSelection().currentItem();
     if (auto* square = dynamic_cast<FootprintSquareItem*>(footprintItem)) {
-        auto* spinbox = new DoubleSpinBox(this, square->squareFootprintValue());
+        auto* spinbox = new DoubleSpinBox(square->squareFootprintValue());
         spinbox->setSingleStep(0.01);
         m_formLayout->addRow("Width ratio:", spinbox);
         connect(spinbox, qOverload<double>(&DoubleSpinBox::baseValueChanged), [=](double newValue) {
@@ -54,7 +54,7 @@ void FootprintCorrectionEditor::createFootprintWidgets()
             emit dataChanged();
         });
     } else if (auto* gauss = dynamic_cast<FootprintGaussianItem*>(footprintItem)) {
-        auto* spinbox = new DoubleSpinBox(this, gauss->gaussianFootprintValue());
+        auto* spinbox = new DoubleSpinBox(gauss->gaussianFootprintValue());
         spinbox->setSingleStep(0.01);
         m_formLayout->addRow("Width ratio:", spinbox);
         connect(spinbox, qOverload<double>(&DoubleSpinBox::baseValueChanged), [=](double newValue) {

GUI/View/Instrument/PolarizationAnalysisEditor.cpp

@@ -40,10 +40,10 @@ PolarizationAnalysisEditor::PolarizationAnalysisEditor(QWidget* parent, Instrume
     addVector(formlayout, m_instrument->polarization());
     addVector(formlayout, m_instrument->analyzerDirection());
     formlayout->addRow(GUI::Util::labelWithUnit(m_instrument->analyzerEfficiency()) + ":",
-                       createSpinBox(polarizerAnalyzerWidget, m_instrument->analyzerEfficiency()));
+                       createSpinBox(m_instrument->analyzerEfficiency()));
     formlayout->addRow(
         GUI::Util::labelWithUnit(m_instrument->analyzerTotalTransmission()) + ":",
-        createSpinBox(polarizerAnalyzerWidget, m_instrument->analyzerTotalTransmission()));
+        createSpinBox(m_instrument->analyzerTotalTransmission()));
 
     layout->addWidget(polarizerAnalyzerWidget);
     polarizerAnalyzerWidget->setVisible(m_instrument->withPolarizerAnalyzer());
@@ -57,9 +57,9 @@ PolarizationAnalysisEditor::PolarizationAnalysisEditor(QWidget* parent, Instrume
     GroupBoxCollapser::installIntoGroupBox(this);
 }
 
-DoubleSpinBox* PolarizationAnalysisEditor::createSpinBox(QWidget* parent, const DoubleDescriptor& d)
+DoubleSpinBox* PolarizationAnalysisEditor::createSpinBox(const DoubleDescriptor& d)
 {
-    auto* sb = new DoubleSpinBox(parent, d);
+    auto* sb = new DoubleSpinBox(d);
     connect(sb, &DoubleSpinBox::baseValueChanged, [=](double v) {
         if (d.get() != v) {
             d.set(v);
@@ -75,7 +75,7 @@ void PolarizationAnalysisEditor::addVector(QFormLayout* parentLayout, const Vect
 
     const auto add = [&](const DoubleDescriptor& d) {
         layout->addWidget(new QLabel(GUI::Util::labelWithUnit(d) + ":"));
-        layout->addWidget(createSpinBox(parentLayout->parentWidget(), d));
+        layout->addWidget(createSpinBox(d));
     };
 
     add(d.x);

GUI/View/Instrument/PolarizationAnalysisEditor.h

@@ -36,7 +36,7 @@ signals:
     void dataChanged();
 
 private:
-    DoubleSpinBox* createSpinBox(QWidget* parent, const DoubleDescriptor& d);
+    DoubleSpinBox* createSpinBox(const DoubleDescriptor& d);
     void addVector(QFormLayout* parentLayout, const VectorDescriptor& d);
 
     InstrumentItem* m_instrument;

GUI/View/Instrument/RectangularDetectorEditor.cpp

@@ -47,7 +47,7 @@ RectangularDetectorEditor::RectangularDetectorEditor(QWidget* parent,
     xAxisNbinsSpinBox->setValue(detector->xSize());
     xAxisFormLayout->addRow("Nbins:", xAxisNbinsSpinBox);
 
-    auto* widthSpinBox = new DoubleSpinBox(xAxisGroupBox, detector->width());
+    auto* widthSpinBox = new DoubleSpinBox(detector->width());
     xAxisFormLayout->addRow("Width [mm]:", widthSpinBox);
 
     connect(xAxisNbinsSpinBox, qOverload<int>(&QSpinBox::valueChanged), [=](int newValue) {
@@ -74,7 +74,7 @@ RectangularDetectorEditor::RectangularDetectorEditor(QWidget* parent,
     yAxisNbinsSpinBox->setValue(detector->ySize());
     yAxisFormLayout->addRow("Nbins:", yAxisNbinsSpinBox);
 
-    auto* heightSpinBox = new DoubleSpinBox(yAxisGroupBox, detector->height());
+    auto* heightSpinBox = new DoubleSpinBox(detector->height());
     yAxisFormLayout->addRow("Height [mm]:", heightSpinBox);
 
     connect(yAxisNbinsSpinBox, qOverload<int>(&QSpinBox::valueChanged), [=](int newValue) {

GUI/View/Instrument/ResolutionFunctionEditor.cpp

@@ -35,7 +35,7 @@ ResolutionFunctionEditor::ResolutionFunctionEditor(Unit unit, QWidget* parent, D
         GUI::Util::createComboBox(item->resolutionFunctionSelection(), [=](int) {
             createResolutionWidgets();
             emit dataChanged();
-        }, false);
+        });
     m_formLayout->addRow("Type:", typeCombo);
 
     GroupBoxCollapser::installIntoGroupBox(this);

GUI/View/Instrument/SphericalAxisEditor.cpp

@@ -22,7 +22,7 @@ SphericalAxisForm::SphericalAxisForm(QFormLayout* form, QWidget* parent)
     : QObject(parent)
     , m_item(nullptr)
 {
-    m_nbinsSpinBox = new SafeSpinBox(false);
+    m_nbinsSpinBox = new SafeSpinBox;
     m_nbinsSpinBox->setRange(1, 65536);
     connect(m_nbinsSpinBox, qOverload<int>(&QSpinBox::valueChanged), this,
             &SphericalAxisForm::onNbinsValueChanged);

GUI/View/Mask/MaskEditorPropertyPanel.cpp

@@ -222,7 +222,7 @@ void MaskEditorPropertyPanel::createMaskEditorUI()
 
 void MaskEditorPropertyPanel::addMaskSpinBox(DoubleDescriptor d)
 {
-    auto* spinBox = new DoubleSpinBox(m_maskPropertiesLayout->parentWidget(), d);
+    auto* spinBox = new DoubleSpinBox(d);
     spinBox->setBaseValue(d.get());
     QObject::connect(spinBox, &DoubleSpinBox::baseValueChanged,
                      [=](double newValue) { d.set(newValue); });

GUI/View/PlotUtil/IntensityDataPropertyWidget.cpp

@@ -73,11 +73,11 @@ void IntensityDataPropertyWidget::setItem(QVector<IntensityDataItem*> items)
     if (!first_item)
         return;
 
-    m_mainLayout->addRow("Axes units:", GUI::Util::createComboBox(
+    m_mainLayout->addRow("Axes units:", GUI::Util::createComboBoxUpdScroll(
         first_item->axesUnits(), &m_updaters,
         [=](int newIndex) { FOR_OTHER_ITEMS item->axesUnits().setCurrentIndex(newIndex); }));
 
-    m_mainLayout->addRow("Color scheme:", GUI::Util::createComboBox(
+    m_mainLayout->addRow("Color scheme:", GUI::Util::createComboBoxUpdScroll(
         first_item->gradient(), &m_updaters,
         [=](int newIndex) { FOR_OTHER_ITEMS item->gradient().setCurrentIndex(newIndex); }));
 
@@ -92,11 +92,11 @@ void IntensityDataPropertyWidget::setItem(QVector<IntensityDataItem*> items)
     xFormLayout->setContentsMargins(0, 0, 0, 0);
     xFormLayout->setSpacing(5);
 
-    xFormLayout->addRow("Min:", GUI::Util::createDoubleSpinbox(
+    xFormLayout->addRow("Min:", GUI::Util::createDoubleSpinboxScroll(
         first_item->xAxisItem()->min(), &m_updaters,
         [=](double newValue) { FOR_OTHER_ITEMS item->xAxisItem()->min().set(newValue); }));
 
-    xFormLayout->addRow("Max:", GUI::Util::createDoubleSpinbox(
+    xFormLayout->addRow("Max:", GUI::Util::createDoubleSpinboxScroll(
         first_item->xAxisItem()->max(), &m_updaters,
         [=](double newValue) { FOR_OTHER_ITEMS item->xAxisItem()->max().set(newValue); }));
 
@@ -113,11 +113,11 @@ void IntensityDataPropertyWidget::setItem(QVector<IntensityDataItem*> items)
     yFormLayout->setContentsMargins(0, 0, 0, 0);
     yFormLayout->setSpacing(5);
 
-    yFormLayout->addRow("Min:", GUI::Util::createDoubleSpinbox(
+    yFormLayout->addRow("Min:", GUI::Util::createDoubleSpinboxScroll(
         first_item->yAxisItem()->min(), &m_updaters,
         [=](double newValue) { FOR_OTHER_ITEMS item->yAxisItem()->min().set(newValue); }));
 
-    yFormLayout->addRow("Max:", GUI::Util::createDoubleSpinbox(
+    yFormLayout->addRow("Max:", GUI::Util::createDoubleSpinboxScroll(
         first_item->yAxisItem()->max(), &m_updaters,
         [=](double newValue) { FOR_OTHER_ITEMS item->yAxisItem()->max().set(newValue); }));
 
@@ -134,11 +134,11 @@ void IntensityDataPropertyWidget::setItem(QVector<IntensityDataItem*> items)
     zFormLayout->setContentsMargins(0, 0, 0, 0);
     zFormLayout->setSpacing(5);
 
-    zFormLayout->addRow("Min:", GUI::Util::createDoubleSpinbox(
+    zFormLayout->addRow("Min:", GUI::Util::createDoubleSpinboxScroll(
         first_item->zAxisItem()->min(), &m_updaters,
         [=](double newValue) { FOR_OTHER_ITEMS item->zAxisItem()->min().set(newValue); }));
 
-    zFormLayout->addRow("Max:", GUI::Util::createDoubleSpinbox(
+    zFormLayout->addRow("Max:", GUI::Util::createDoubleSpinboxScroll(
         first_item->zAxisItem()->max(), &m_updaters,
         [=](double newValue) { FOR_OTHER_ITEMS item->zAxisItem()->max().set(newValue); }));
 

GUI/View/PropertyEditor/SpecularDataPropertyWidget.cpp

@@ -77,7 +77,7 @@ void SpecularDataPropertyWidget::setItem(QVector<SpecularDataItem*> items)
     if (!first_item)
         return;
 
-    m_mainLayout->addRow("Axes units:", GUI::Util::createComboBox(
+    m_mainLayout->addRow("Axes units:", GUI::Util::createComboBoxUpdScroll(
         first_item->axesUnits(), &m_updaters,
         [=](int newIndex) { FOR_OTHER_ITEMS item->axesUnits().setCurrentIndex(newIndex); }));
 
@@ -87,11 +87,11 @@ void SpecularDataPropertyWidget::setItem(QVector<SpecularDataItem*> items)
     xFormLayout->setContentsMargins(0, 0, 0, 0);
     xFormLayout->setSpacing(5);
 
-    xFormLayout->addRow("Min:", GUI::Util::createDoubleSpinbox(
+    xFormLayout->addRow("Min:", GUI::Util::createDoubleSpinboxScroll(
         first_item->xAxisItem()->min(), &m_updaters,
         [=](double newValue) { FOR_OTHER_ITEMS item->xAxisItem()->min().set(newValue); }));
 
-    xFormLayout->addRow("Max:", GUI::Util::createDoubleSpinbox(
+    xFormLayout->addRow("Max:", GUI::Util::createDoubleSpinboxScroll(
         first_item->xAxisItem()->max(), &m_updaters,
         [=](double newValue) { FOR_OTHER_ITEMS item->xAxisItem()->max().set(newValue); }));
 
@@ -108,11 +108,11 @@ void SpecularDataPropertyWidget::setItem(QVector<SpecularDataItem*> items)
     yFormLayout->setContentsMargins(0, 0, 0, 0);
     yFormLayout->setSpacing(5);
 
-    yFormLayout->addRow("Min:", GUI::Util::createDoubleSpinbox(
+    yFormLayout->addRow("Min:", GUI::Util::createDoubleSpinboxScroll(
         first_item->yAxisItem()->min(), &m_updaters,
         [=](double newValue) { FOR_OTHER_ITEMS item->yAxisItem()->min().set(newValue); }));
 
-    yFormLayout->addRow("Max:", GUI::Util::createDoubleSpinbox(
+    yFormLayout->addRow("Max:", GUI::Util::createDoubleSpinboxScroll(
         first_item->yAxisItem()->max(), &m_updaters,
         [=](double newValue) { FOR_OTHER_ITEMS item->yAxisItem()->max().set(newValue); }));
 

GUI/View/SampleDesigner/FormLayouter.cpp

@@ -183,7 +183,7 @@ void FormLayouter::insertValue(int row, const DoubleDescriptor& d,
     label->setAlignment(Qt::AlignLeft | Qt::AlignBottom);
     label->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::MinimumExpanding);
 
-    auto* editor = new DoubleSpinBox(m_formLayout->parentWidget(), d);
+    auto* editor = new DoubleSpinBox(d);
     QObject::connect(editor, &DoubleSpinBox::baseValueChanged, onValueChange);
 
     label->setBuddy(editor);

GUI/View/SampleDesigner/LayerEditorUtils.cpp

@@ -83,7 +83,7 @@ void LayerEditorUtils::addMultiPropertyToGrid(QGridLayout* m_gridLayout, int fir
 {
     int col = firstCol;
     for (const auto& valueDescriptor : valueDescriptors) {
-        auto* editor = new DoubleSpinBox(m_gridLayout->parentWidget(), valueDescriptor);
+        auto* editor = new DoubleSpinBox(valueDescriptor);
         QObject::connect(editor, &DoubleSpinBox::baseValueChanged,
                          [=](double newValue) { setNewValue(newValue, valueDescriptor); });