rm unused c'tor

GUI/Model/MakeItem/ItemCatalog.cpp

@@ -48,6 +48,7 @@
 #include "GUI/Model/Item/ParticleLayoutItem.h"
 #include "GUI/Model/BaseItem/PropertyItem.h"
 #include "GUI/Model/Item/RealLimitsItems.h"
+#include "GUI/Model/Item/VectorItem.h"
 
 ItemCatalog::ItemCatalog()
 {

GUI/Model/Fit/FitParameterHelper.cpp → GUI/Model/Model/FitParameterHelper.cpp

@@ -2,7 +2,7 @@
 //
 //  BornAgain: simulate and fit reflection and scattering
 //
-//! @file      GUI/Model/Fit/FitParameterHelper.cpp
+//! @file      GUI/Model/Model/FitParameterHelper.cpp
 //! @brief     Implements namespace FitModelHelper
 //!
 //! @homepage  http://www.bornagainproject.org
@@ -12,7 +12,7 @@
 //
 //  ************************************************************************************************
 
-#include "GUI/Model/Fit/FitParameterHelper.h"
+#include "GUI/Model/Model/FitParameterHelper.h"
 #include "GUI/Model/Item/FitParameterContainerItem.h"
 #include "GUI/Model/Item/FitParameterItem.h"
 #include "GUI/Model/Item/FitParameterLinkItem.h"

GUI/Model/Fit/FitParameterHelper.h → GUI/Model/Model/FitParameterHelper.h

@@ -2,7 +2,7 @@
 //
 //  BornAgain: simulate and fit reflection and scattering
 //
-//! @file      GUI/Model/Fit/FitParameterHelper.h
+//! @file      GUI/Model/Model/FitParameterHelper.h
 //! @brief     Defines namespace FitParameterHelper
 //!
 //! @homepage  http://www.bornagainproject.org
@@ -12,8 +12,8 @@
 //
 //  ************************************************************************************************
 
-#ifndef BORNAGAIN_GUI_MODEL_FIT_FITPARAMETERHELPER_H
-#define BORNAGAIN_GUI_MODEL_FIT_FITPARAMETERHELPER_H
+#ifndef BORNAGAIN_GUI_MODEL_MODEL_FITPARAMETERHELPER_H
+#define BORNAGAIN_GUI_MODEL_MODEL_FITPARAMETERHELPER_H
 
 #include <QStringList>
 
@@ -32,4 +32,4 @@ ParameterItem* getParameterItem(FitParameterContainerItem* container, const QStr
 
 } // namespace FitParameterHelper
 
-#endif // BORNAGAIN_GUI_MODEL_FIT_FITPARAMETERHELPER_H
+#endif // BORNAGAIN_GUI_MODEL_MODEL_FITPARAMETERHELPER_H

GUI/Model/Model/FitParameterModel.cpp

@@ -14,7 +14,7 @@
 
 #include "GUI/Model/Model/FitParameterModel.h"
 #include "GUI/Model/Item/FitParameterContainerItem.h"
-#include "GUI/Model/Fit/FitParameterHelper.h"
+#include "GUI/Model/Model/FitParameterHelper.h"
 #include "GUI/Model/Item/FitParameterItem.h"
 #include "GUI/Model/Item/FitParameterLinkItem.h"
 #include "GUI/Model/Model/JobModel.h"

GUI/Model/Model/ParameterTuningModel.cpp

@@ -13,7 +13,7 @@
 //  ************************************************************************************************
 
 #include "GUI/Model/Model/ParameterTuningModel.h"
-#include "GUI/Model/Fit/FitParameterHelper.h"
+#include "GUI/Model/Model/FitParameterHelper.h"
 #include "GUI/Model/Item/ParameterTreeItems.h"
 #include "GUI/Model/Model/SessionXML.h"
 #include <QMimeData>

GUI/Model/Types/VectorDescriptor.h

@@ -16,7 +16,7 @@
 #define BORNAGAIN_GUI_MODEL_TYPES_VECTORDESCRIPTOR_H
 
 #include "GUI/Model/Types/DoubleDescriptor.h"
-#include "GUI/Model/Item/VectorItem.h"
+#include <heinz/Vectors3D.h>
 
 //! Describes properties of a 3D vector, consisting of three double values.
 //!
@@ -27,19 +27,6 @@ class VectorDescriptor {
 public:
     VectorDescriptor() = default;
 
-    //! Operates on a VectorItem.
-    //!
-    //! The settings (like decimals, limits) are taken from the item.
-    //! Only for easier migration. Should be removed after SessionItem refactoring.
-    VectorDescriptor(VectorItem* item, const variant<QString, Unit>& unit)
-        : label(item->displayName())
-        , tooltip(item->toolTip())
-        , x(item->xItem(), unit)
-        , y(item->yItem(), unit)
-        , z(item->zItem(), unit)
-    {
-    }
-
     VectorDescriptor(const QString& label, const QString& tooltip, double* xVar, double* yVar,
                      double* zVar, const variant<QString, Unit>& unit)
         : label(label)

GUI/View/Fit/FitParameterWidget.cpp

@@ -14,7 +14,7 @@
 
 #include "GUI/View/Fit/FitParameterWidget.h"
 #include "GUI/Model/Item/FitParameterContainerItem.h"
-#include "GUI/Model/Fit/FitParameterHelper.h"
+#include "GUI/Model/Model/FitParameterHelper.h"
 #include "GUI/Model/Item/FitParameterItem.h"
 #include "GUI/Model/Item/FitParameterLinkItem.h"
 #include "GUI/Model/Model/FitParameterModel.h"

GUI/View/SampleDesigner/MaterialInplaceForm.cpp

@@ -13,6 +13,7 @@
 //  ************************************************************************************************
 
 #include "GUI/View/SampleDesigner/MaterialInplaceForm.h"
+#include "Base/Util/Assert.h"
 #include "GUI/Model/Item/MaterialItem.h"
 #include "GUI/Model/Model/MaterialModel.h"
 #include "GUI/Model/Item/ItemWithMaterial.h"