Skip to content
Snippets Groups Projects
Commit 2d9c02c0 authored by Wuttke, Joachim's avatar Wuttke, Joachim
Browse files

rm unit from resolution distribution

parent 9f1927a8
No related branches found
No related tags found
1 merge request!2003In GUI, remove option to switch beteen nm and angstrom, degrees and radians.
...@@ -48,17 +48,11 @@ const QMap<FlatDetector::NominalNormal, QString> alignment_names_map = { ...@@ -48,17 +48,11 @@ const QMap<FlatDetector::NominalNormal, QString> alignment_names_map = {
{FlatDetector::T, "Perpendicular to direct beam"}, {FlatDetector::T, "Perpendicular to direct beam"},
{FlatDetector::R, "Perpendicular to reflected beam"}}; {FlatDetector::R, "Perpendicular to reflected beam"}};
void initResolutionFunction(ResolutionFunctionItem* newFunc, const ResolutionFunctionItem*)
{
newFunc->setUnit("mm");
}
} // namespace } // namespace
DetectorItem::DetectorItem() DetectorItem::DetectorItem()
{ {
m_resolutionFunction.initWithInitializer("Resolution function", "Detector resolution function", m_resolutionFunction.init("Resolution function", "Detector resolution function");
initResolutionFunction);
m_xSize = 100; m_xSize = 100;
m_ySize = 100; m_ySize = 100;
......
...@@ -17,19 +17,13 @@ ...@@ -17,19 +17,13 @@
#include "GUI/Model/Detector/ResolutionFunctionItems.h" #include "GUI/Model/Detector/ResolutionFunctionItems.h"
ResolutionFunctionItem* ResolutionFunctionItem*
ResolutionFunctionItemCatalog::create(Type type, const std::variant<QString, Unit>& unit) ResolutionFunctionItemCatalog::create(Type type)
{ {
switch (type) { switch (type) {
case Type::None: { case Type::None:
auto* p = new ResolutionFunctionNoneItem(); return new ResolutionFunctionNoneItem();
p->setUnit(unit); case Type::Gaussian:
return p; return new ResolutionFunction2DGaussianItem();
}
case Type::Gaussian: {
auto* p = new ResolutionFunction2DGaussianItem();
p->setUnit(unit);
return p;
}
} }
ASSERT_NEVER; ASSERT_NEVER;
} }
......
...@@ -16,9 +16,7 @@ ...@@ -16,9 +16,7 @@
#define BORNAGAIN_GUI_MODEL_DETECTOR_RESOLUTIONFUNCTIONITEMCATALOG_H #define BORNAGAIN_GUI_MODEL_DETECTOR_RESOLUTIONFUNCTIONITEMCATALOG_H
#include "GUI/Support/Type/UiInfo.h" #include "GUI/Support/Type/UiInfo.h"
#include "GUI/Support/Type/Unit.h"
#include <QVector> #include <QVector>
#include <variant>
class ResolutionFunctionItem; class ResolutionFunctionItem;
...@@ -31,8 +29,7 @@ public: ...@@ -31,8 +29,7 @@ public:
enum class Type : uint8_t { None = 0, Gaussian = 1 }; enum class Type : uint8_t { None = 0, Gaussian = 1 };
//! Creates the item of the given type. //! Creates the item of the given type.
static ResolutionFunctionItem* create(Type type, static ResolutionFunctionItem* create(Type type);
const std::variant<QString, Unit>& unit = Unit::unitless);
//! List of available types, sorted as expected in the UI. //! List of available types, sorted as expected in the UI.
static QVector<Type> types(); static QVector<Type> types();
......
...@@ -45,12 +45,6 @@ ResolutionFunction2DGaussianItem::createResolutionFunction(double scale) const ...@@ -45,12 +45,6 @@ ResolutionFunction2DGaussianItem::createResolutionFunction(double scale) const
return std::make_unique<ResolutionFunction2DGaussian>(scale * m_sigmaX, scale * m_sigmaY); return std::make_unique<ResolutionFunction2DGaussian>(scale * m_sigmaX, scale * m_sigmaY);
} }
void ResolutionFunction2DGaussianItem::setUnit(const std::variant<QString, Unit>& unit)
{
m_sigmaX.setUnit(unit);
m_sigmaY.setUnit(unit);
}
void ResolutionFunction2DGaussianItem::writeTo(QXmlStreamWriter* w) const void ResolutionFunction2DGaussianItem::writeTo(QXmlStreamWriter* w) const
{ {
XML::writeAttribute(w, XML::Attrib::version, uint(1)); XML::writeAttribute(w, XML::Attrib::version, uint(1));
......
...@@ -28,9 +28,6 @@ public: ...@@ -28,9 +28,6 @@ public:
virtual std::unique_ptr<IResolutionFunction2D> virtual std::unique_ptr<IResolutionFunction2D>
createResolutionFunction(double scale = 1.0) const = 0; createResolutionFunction(double scale = 1.0) const = 0;
//! Set the unit of the distributed value
virtual void setUnit(const std::variant<QString, Unit>&) {}
virtual void writeTo(QXmlStreamWriter*) const {} virtual void writeTo(QXmlStreamWriter*) const {}
virtual void readFrom(QXmlStreamReader*) {} virtual void readFrom(QXmlStreamReader*) {}
}; };
...@@ -47,8 +44,6 @@ public: ...@@ -47,8 +44,6 @@ public:
std::unique_ptr<IResolutionFunction2D> std::unique_ptr<IResolutionFunction2D>
createResolutionFunction(double scale = 1.0) const override; createResolutionFunction(double scale = 1.0) const override;
void setUnit(const std::variant<QString, Unit>& unit) override;
void writeTo(QXmlStreamWriter* w) const override; void writeTo(QXmlStreamWriter* w) const override;
void readFrom(QXmlStreamReader* r) override; void readFrom(QXmlStreamReader* r) override;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment