Merge branch 'fixes' into 'main'

crash fix, behavior fix and cleanup

See merge request !647

GUI/Model/Item/RectangularDetectorItem.cpp

@@ -109,10 +109,8 @@ void RectangularDetectorItem::serialize(Serializer& s)
     s.rw(m_v0);
     s.rw(m_distance);
 
-    if (s.isReading()) {
-        m_detectorAlignment = static_cast<RectangularDetector::EDetectorArrangement>(alignment);
-        updateTooltips();
-    }
+    if (s.isReading())
+        setDetectorAlignment(static_cast<RectangularDetector::EDetectorArrangement>(alignment));
 }
 
 void RectangularDetectorItem::setDetectorAlignment(

GUI/View/Instrument/InstrumentLibraryEditor.cpp

@@ -129,6 +129,7 @@ void InstrumentLibraryEditor::execAdd(const InstrumentItem& instrumentToAdd)
     m_ui->buttonBox->button(QDialogButtonBox::Cancel)->hide();
 
     QModelIndex index = m_treeModel->indexForItem(addedInstrument);
+    m_ui->treeView->expandAll();
     m_ui->treeView->setCurrentIndex(index);
     m_ui->treeView->scrollTo(index, QAbstractItemView::PositionAtTop);
     setModal(true);

GUI/View/PlotUtil/IntensityDataPropertyWidget.cpp

@@ -99,6 +99,8 @@ void IntensityDataPropertyWidget::setItem(IntensityDataItem* item)
     // react on external changes (e.g. zooming in customplot shall update the axis values)
     item->mapper()->setOnChildPropertyChange(
         [=](SessionItem*, const QString&) { updateUIValues(); }, this);
+
+    item->mapper()->setOnItemDestroy([this](SessionItem*) { m_item = nullptr; }, this);
 }
 
 QWidget* IntensityDataPropertyWidget::createDoubleSpinbox(DoubleDescriptor d)