PeTrack merge requestshttps://jugit.fz-juelich.de/ped-dyn-emp/petrack/-/merge_requests2021-05-03T11:21:33+02:00https://jugit.fz-juelich.de/ped-dyn-emp/petrack/-/merge_requests/69Resolve "Composition over Inheritance"2021-05-03T11:21:33+02:00d.kilicResolve "Composition over Inheritance"This MR includes:
- TrackPoint is now a struct (since it has no class invariant)
- TrackPerson doesn't inherit from QList anymore, but instead has a `std::deque` member variable for its points
- Tracker doesn't inherit from QList anymor...This MR includes:
- TrackPoint is now a struct (since it has no class invariant)
- TrackPerson doesn't inherit from QList anymore, but instead has a `std::deque` member variable for its points
- Tracker doesn't inherit from QList anymore, but instead has a `std::vector` member variable for its TrackPersons
- Adjustments to the interface of TrackPoint, TrackPerson and Tracker so that the code still works
This MR does not close #85, since the real pendant (TrackerReal & Co) are not yet migrated to work via member variables.
I also want to note, the change is done really rudimentary here. So the API of the classes is still not preserving all class invariants (e.g. one still could add an Point to a Person without updating its member last_frame). But adding that to this MR would result in a too big difference.
This MR changes interfaces of commonly used classes, so it should be communicated to all devs before merging. Also, it is more prone to complicated merges because of that, so it may be reviewed when no merge is planned for the near future.
Relates #85https://jugit.fz-juelich.de/ped-dyn-emp/petrack/-/merge_requests/8WIP: Resolve "Reformat project with clang-format"2020-12-17T09:19:50+01:00d.kilicWIP: Resolve "Reformat project with clang-format"Merge request to discuss clang-format options for the formatting of the repository. Based on the rules from TODO.txt:
* Klammern von Bloecken beginnen immer in neuer Zeile
* einruecken von 4 Leerzeichen (kein Tab)
To check the format yo...Merge request to discuss clang-format options for the formatting of the repository. Based on the rules from TODO.txt:
* Klammern von Bloecken beginnen immer in neuer Zeile
* einruecken von 4 Leerzeichen (kein Tab)
To check the format yourself:
1. download the .clang-format file
2. go to: https://zed0.co.uk/clang-format-configurator/
3. upload the .clang-format file there
4. (optional) play around with options by yourself and post suggestions here
If you have any remarks please let me know!https://jugit.fz-juelich.de/ped-dyn-emp/petrack/-/merge_requests/55Resolve "Check includes"2020-11-04T10:07:12+01:00d.kilicResolve "Check includes"This MR applies the changes suggested by iwyu, with one correction (mat.inl.hpp to mat.hpp).
Closes #34This MR applies the changes suggested by iwyu, with one correction (mat.inl.hpp to mat.hpp).
Closes #34