From 17a8d199446d85e4b1c49e180364cfa19746d13a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Schr=C3=B6dter=2C=20Tobias?= <t.schroedter@fz-juelich.de> Date: Thu, 23 Feb 2023 13:46:18 +0100 Subject: [PATCH] Allow failure in pre-build check --- .gitlab-ci.yml | 1 + .gitlab/merge_request_templates/merge_request.md | 3 +++ 2 files changed, 4 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 9e8c9e4ae..c64dbcc9a 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -45,6 +45,7 @@ pre-build-checks: stage: pre-build-checks script: - scripts/check-format-cpp.sh + allow_failure: true # Build petrack and petrack unit_tests build_linux: diff --git a/.gitlab/merge_request_templates/merge_request.md b/.gitlab/merge_request_templates/merge_request.md index 5a322092f..2cddf8440 100644 --- a/.gitlab/merge_request_templates/merge_request.md +++ b/.gitlab/merge_request_templates/merge_request.md @@ -3,6 +3,9 @@ # Reviewer Checklist +## Formatting +- [ ] the pre-build checks succeed + ## General code quality - [ ] naming conventions are met (see .clang-tidy for detailed information) - [ ] no static analyzer warnings in new code parts (e.g., use clang-tidy for checking) -- GitLab