Skip to content

Fixed predicted peaks intersecting beam stop

Raza, Zamaan requested to merge beamstop_peaks into develop

Resolves #267 (closed)

Fix in https://jugit.fz-juelich.de/mlz/nsxtool/-/blob/beamstop_peaks/core/shape/ShapeCollection.cpp#L62

The offending commit:

https://jugit.fz-juelich.de/mlz/nsxtool/-/commit/bf96fdfe425b38e780b3c974578a42178cbced9b?page=2

Apparently, the constructor,

std::vector<ReciprocalVector> qs(hkls.size());

results in undefined behaviour. I would guess that the main reason is that there is no reason to expect that there are as many q-vectors as Miller indices.

Edited by Raza, Zamaan

Merge request reports