OpenHKL merge requestshttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests2022-08-12T10:50:27+02:00https://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/519CI: correct syntax for if-conditional2022-08-12T10:50:27+02:00Wuttke, Joachimj.wuttke@fz-juelich.deCI: correct syntax for if-conditionalhttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/516CI: test for scheduled (nightly) run as in BornAgain2022-08-11T12:48:44+02:00Wuttke, Joachimj.wuttke@fz-juelich.deCI: test for scheduled (nightly) run as in BornAgainPrevious version did not work, nightly tests were ignored.
Will merge directly. We'll see tomorrow whether it works (#532).Previous version did not work, nightly tests were ignored.
Will merge directly. We'll see tomorrow whether it works (#532).https://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/511CI: test for scheduled (nightly) run as in BornAgain2022-08-11T08:44:54+02:00Wuttke, Joachimj.wuttke@fz-juelich.deCI: test for scheduled (nightly) run as in BornAgainprevious version did not work, nightly tests were ignoredprevious version did not work, nightly tests were ignoredhttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/508Correct handling of frame indices in detector scene and associated spin boxes2022-08-08T10:20:12+02:00Wuttke, Joachimj.wuttke@fz-juelich.deCorrect handling of frame indices in detector scene and associated spin boxesThis solves the various bugs reported in #515.
For the benefit of not so computer minded users, displayed indices run from 1 to N. This requires conversions at the right places, as internally indices go from 0 to N-1.This solves the various bugs reported in #515.
For the benefit of not so computer minded users, displayed indices run from 1 to N. This requires conversions at the right places, as internally indices go from 0 to N-1.https://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/488TestPeakFinder: correct error message2022-07-15T11:33:03+02:00Wuttke, Joachimj.wuttke@fz-juelich.deTestPeakFinder: correct error messageWuttke, Joachimj.wuttke@fz-juelich.deWuttke, Joachimj.wuttke@fz-juelich.dehttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/13issue00042019-07-09T14:29:24+02:00Schober, Alexanderissue0004Fixed by narrowing down the issue to an abusive 'auto' replaced by 'Eigen::RowVector3d'Fixed by narrowing down the issue to an abusive 'auto' replaced by 'Eigen::RowVector3d'Wuttke, Joachimj.wuttke@fz-juelich.deWuttke, Joachimj.wuttke@fz-juelich.dehttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/518rename Integrator, IPeakIntegrator -> IntegrationProvider, IIntegrator2022-08-11T16:40:11+02:00Wuttke, Joachimj.wuttke@fz-juelich.derename Integrator, IPeakIntegrator -> IntegrationProvider, IIntegratorThis resolves #524.This resolves #524.https://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/517Make Python scripts executable, and copy edit TestTrypsin2022-08-11T15:19:17+02:00Wuttke, Joachimj.wuttke@fz-juelich.deMake Python scripts executable, and copy edit TestTrypsinhttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/513Session::loadRawData(): split off function askRawFileNames2022-08-11T17:34:10+02:00Wuttke, Joachimj.wuttke@fz-juelich.deSession::loadRawData(): split off function askRawFileNames- split long fct, mv some code to local fct
- normalize fct name (w/o prefix _)
- improve comments
- etc- split long fct, mv some code to local fct
- normalize fct name (w/o prefix _)
- improve comments
- etchttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/512Cleanup in mask context2022-08-11T17:03:28+02:00Wuttke, Joachimj.wuttke@fz-juelich.deCleanup in mask context- rm unused fct
- rm unused includes
- spell out `auto`- rm unused fct
- rm unused includes
- spell out `auto`https://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/509rm MeanPeakIntegrator, and further cleanup in integrator context (#526)2022-08-11T08:40:05+02:00Wuttke, Joachimj.wuttke@fz-juelich.derm MeanPeakIntegrator, and further cleanup in integrator context (#526)This resolves #526.This resolves #526.https://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/504Minimizer: rm unused member function, make getter functions const, correct typos2022-08-11T17:34:20+02:00Wuttke, Joachimj.wuttke@fz-juelich.deMinimizer: rm unused member function, make getter functions const, correct typoshttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/499rm rebuild_isotopes_database.py, obsolete after removal of xsection2022-07-22T09:29:58+02:00Wuttke, Joachimj.wuttke@fz-juelich.derm rebuild_isotopes_database.py, obsolete after removal of xsectionThis script was related to the grand plans for including lots of crystallography in NSXTool. After removal of xsection, this script should go as well.This script was related to the grand plans for including lots of crystallography in NSXTool. After removal of xsection, this script should go as well.Wuttke, Joachimj.wuttke@fz-juelich.deWuttke, Joachimj.wuttke@fz-juelich.dehttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/498rm duplicate notebooks, rm output files that do not belong under source control2022-07-20T17:25:42+02:00Wuttke, Joachimj.wuttke@fz-juelich.derm duplicate notebooks, rm output files that do not belong under source controlWuttke, Joachimj.wuttke@fz-juelich.deWuttke, Joachimj.wuttke@fz-juelich.dehttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/267rm duplicate includes2021-06-18T08:57:07+02:00Wuttke, Joachimj.wuttke@fz-juelich.derm duplicate includesdetected with tool 'deheader'.detected with tool 'deheader'.https://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/222Code embellishment as suggested by clang-tidy2021-03-24T08:32:40+01:00Wuttke, Joachimj.wuttke@fz-juelich.deCode embellishment as suggested by clang-tidyNumber of disabled, but promising clang checks down from about 40 to 15.Number of disabled, but promising clang checks down from about 40 to 15.https://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/221Support clang-tidy (all current warnings disabled)2021-03-22T13:16:23+01:00Wuttke, Joachimj.wuttke@fz-juelich.deSupport clang-tidy (all current warnings disabled)Add file `.clang-tidy` and CMake option `NSX_TIDY` to support clang-tidy checks.
Use: `cmake .. -DNSX_TIDY=ON -DNSX_PYTHON=OFF -DNSX_TESTDATA_DIR=<path> && make -j4`
A lot of checks are disabled. On my system (with clang11), no single ...Add file `.clang-tidy` and CMake option `NSX_TIDY` to support clang-tidy checks.
Use: `cmake .. -DNSX_TIDY=ON -DNSX_PYTHON=OFF -DNSX_TESTDATA_DIR=<path> && make -j4`
A lot of checks are disabled. On my system (with clang11), no single warning is generated. The intended use is to remove disabling entries from the bottom of `.clang-tidy`, run cmake and make, get warnings, and fix them in the sources.https://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/107rm directory doc (most contents moved to repository nsx-intern)2020-07-28T08:54:01+02:00Wuttke, Joachimj.wuttke@fz-juelich.derm directory doc (most contents moved to repository nsx-intern)https://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/105Experiment API changes: assignUnitCell, addUnitCell2020-07-24T11:12:08+02:00Wuttke, Joachimj.wuttke@fz-juelich.deExperiment API changes: assignUnitCell, addUnitCellhttps://jugit.fz-juelich.de/mlz/openhkl/-/merge_requests/103rename SessionExperiment -> Project; more const's; mv #include's out of header2020-07-24T07:15:50+02:00Wuttke, Joachimj.wuttke@fz-juelich.derename SessionExperiment -> Project; more const's; mv #include's out of header