Follow-up from "Second round of refactoring for Experiment class"
The following discussions from !109 (merged) should be addressed:
-
@j.wuttke started a discussion: (+1 comment) Where name is either given as an argument, or taken from data->filename. I find this too complicated. Would the following work:
- Equip DataSet with a function
name()
ornonemptyName()
ornameOrFilename()
that always returns a nonempty name. - Remove name from the argument list of
DataHandler::addData
. - Then the remaining argument
data
can be made const.
- Equip DataSet with a function
-
@j.wuttke started a discussion: in a subsequent refactoring, we should get rid of these copy commands: let
integrator
take aparams
constant, and access elements ofparams
where they are actually used.