Mac package broken by recent refactoring (install_name_tool complains about duplicate libraries)

added URGENT deployment release-critical labels

changed the description

mentioned in merge request !2498 (merged)

changed the description

Output from mac_package.py, source lines

for ref, dst in pkg.ref_dst_tbl.items():
    if not dst:
        raise AssertionError("%s: reference '%s' is not resolved" % (TITLE, ref))
    print("  + {%s} => %s" % (ref, dst.replace(pkg_root, PKGROOT)))

before the bug was introduced:

* MacOS Package: Building reference-destination table...
  + {@rpath/_libBornAgainResample.so} => <PKG-ROOT>/lib/_libBornAgainResample.so
  + {@rpath/_libBornAgainSample.so} => <PKG-ROOT>/lib/_libBornAgainSample.so
  + {@rpath/_libBornAgainParam.so} => <PKG-ROOT>/lib/_libBornAgainParam.so
  + {@rpath/_libBornAgainBase.so} => <PKG-ROOT>/lib/_libBornAgainBase.so
  + {/opt/homebrew/opt/fftw/lib/libfftw3.3.dylib} => <PKG-ROOT>/lib/extra/libfftw3.3.dylib
  + {@rpath/_libBornAgainFit.so} => <PKG-ROOT>/lib/_libBornAgainFit.so
  + {/opt/homebrew/opt/boost/lib/libboost_iostreams-mt.dylib} => <PKG-ROOT>/lib/extra/libboost_iostreams-mt.dylib
  + {/opt/homebrew/opt/boost/lib/libboost_program_options-mt.dylib} => <PKG-ROOT>/lib/extra/libboost_program_options-mt.dylib
  + {@rpath/libformfactor.0.3.1.dylib} => <PKG-ROOT>/lib/extra/libformfactor.0.3.1.dylib
  + {@rpath/_libBornAgainPyCore.so} => <PKG-ROOT>/lib/_libBornAgainPyCore.so
  + {@rpath/_libBornAgainDevice.so} => <PKG-ROOT>/lib/_libBornAgainDevice.so
  + {/opt/homebrew/opt/libtiff/lib/libtiff.6.dylib} => <PKG-ROOT>/lib/extra/libtiff.6.dylib
  + {/opt/homebrew/opt/libtiff/lib/libtiffxx.6.dylib} => <PKG-ROOT>/lib/extra/libtiffxx.6.dylib
  + {@rpath/_libBornAgainSim.so} => <PKG-ROOT>/lib/_libBornAgainSim.so
  + {@rpath/libcerf.2.dylib} => <PKG-ROOT>/lib/extra/libcerf.2.dylib
  + {/opt/homebrew/opt/zstd/lib/libzstd.1.dylib} => <PKG-ROOT>/lib/extra/libzstd.1.dylib
  + {/opt/homebrew/opt/xz/lib/liblzma.5.dylib} => <PKG-ROOT>/lib/extra/liblzma.5.dylib
  + {/opt/homebrew/opt/jpeg-turbo/lib/libjpeg.8.dylib} => <PKG-ROOT>/lib/extra/libjpeg.8.dylib
  + {/opt/homebrew/Cellar/libtiff/4.6.0/lib/libtiff.6.dylib} => <PKG-ROOT>/lib/extra/libtiff.6.dylib
* MacOS Package: Python dependence of package libraries:

with bug:

* MacOS Package: Building reference-destination table...
  + {@rpath/_libBornAgainParam.so} => <PKG-ROOT>/lib/extra/_libBornAgainParam.so
  + {@rpath/_libBornAgainBase.so} => <PKG-ROOT>/lib/extra/_libBornAgainBase.so
  + {@rpath/_libBornAgainFit.so} => <PKG-ROOT>/lib/extra/_libBornAgainFit.so
  + {@rpath/libfftw3.3.dylib} => <PKG-ROOT>/lib/extra/libfftw3.3.dylib
  + {@rpath/libboost_iostreams-mt.dylib} => <PKG-ROOT>/lib/extra/libboost_iostreams-mt.dylib
  + {@rpath/libboost_program_options-mt.dylib} => <PKG-ROOT>/lib/extra/libboost_program_options-mt.dylib
  + {@rpath/_libBornAgainSim.so} => <PKG-ROOT>/lib/extra/_libBornAgainSim.so
  + {@rpath/_libBornAgainDevice.so} => <PKG-ROOT>/lib/extra/_libBornAgainDevice.so
  + {@rpath/_libBornAgainResample.so} => <PKG-ROOT>/lib/extra/_libBornAgainResample.so
  + {@rpath/libcerf.2.dylib} => <PKG-ROOT>/lib/extra/libcerf.2.dylib
  + {@rpath/_libBornAgainSample.so} => <PKG-ROOT>/lib/extra/_libBornAgainSample.so
  + {@rpath/libformfactor.0.3.1.dylib} => <PKG-ROOT>/lib/extra/libformfactor.0.3.1.dylib
  + {@rpath/_libBornAgainPyCore.so} => <PKG-ROOT>/lib/extra/_libBornAgainPyCore.so
  + {@rpath/libtiff.6.dylib} => <PKG-ROOT>/lib/extra/libtiff.6.dylib
  + {@rpath/libtiffxx.6.dylib} => <PKG-ROOT>/lib/extra/libtiffxx.6.dylib
  + {@rpath/_libBornAgainGUI.so} => <PKG-ROOT>/lib/_libBornAgainGUI.so
  + {/opt/homebrew/opt/qt/lib/QtOpenGLWidgets.framework/Versions/A/QtOpenGLWidgets} => <PKG-ROOT>/Frameworks/Qt/QtOpenGLWidgets.framework/QtOpenGLWidgets
  + {/opt/homebrew/opt/libtiff/lib/libtiff.6.dylib} => <PKG-ROOT>/lib/extra/libtiff.6.dylib
  + {/opt/homebrew/opt/libtiff/lib/libtiffxx.6.dylib} => <PKG-ROOT>/lib/extra/libtiffxx.6.dylib
  + {/opt/homebrew/opt/fftw/lib/libfftw3.3.dylib} => <PKG-ROOT>/lib/extra/libfftw3.3.dylib
  + {/opt/homebrew/opt/boost/lib/libboost_iostreams-mt.dylib} => <PKG-ROOT>/lib/extra/libboost_iostreams-mt.dylib
  + {/opt/homebrew/opt/boost/lib/libboost_program_options-mt.dylib} => <PKG-ROOT>/lib/extra/libboost_program_options-mt.dylib
  + {/opt/homebrew/opt/qt/lib/QtOpenGL.framework/Versions/A/QtOpenGL} => <PKG-ROOT>/Frameworks/Qt/QtOpenGL.framework/QtOpenGL
  + {/opt/homebrew/opt/qt/lib/QtPrintSupport.framework/Versions/A/QtPrintSupport} => <PKG-ROOT>/Frameworks/Qt/QtPrintSupport.framework/QtPrintSupport
  + {/opt/homebrew/opt/qt/lib/QtWidgets.framework/Versions/A/QtWidgets} => <PKG-ROOT>/Frameworks/Qt/QtWidgets.framework/QtWidgets
  + {/opt/homebrew/opt/qt/lib/QtGui.framework/Versions/A/QtGui} => <PKG-ROOT>/Frameworks/Qt/QtGui.framework/QtGui
  + {/opt/homebrew/opt/qt/lib/QtCore.framework/Versions/A/QtCore} => <PKG-ROOT>/Frameworks/Qt/QtCore.framework/QtCore
  + {@rpath/libzstd.1.dylib} => <PKG-ROOT>/lib/extra/libzstd.1.dylib
error: /Library/Developer/CommandLineTools/usr/bin/install_name_tool: for: /Users/qtisas/builds/wQZpNRfzw/0/mlz/bornagain/build/py/src/bornagain/lib/_libBornAgainParam.so (for architecture arm64) option "-add_rpath /opt/homebrew/Frameworks/Python.framework/Versions/3.11/lib" would duplicate path, file already has LC_RPATH for: /opt/homebrew/Frameworks/Python.framework/Versions/3.11/lib

An earlier divergence in the build logs starts in line 3560 in the section starting with

* MacOS Package: Find dependencies (up to level 10)...
...
==>[L3]

Before the bug was introduced:

  + [rel@rpath]: /Users/Shared/Software/scg/lib/libcerf.2.4.dylib {@rpath/libcerf.2.dylib}
...
 + [rel@rpath]: <PKG-ROOT>/lib/_libBornAgainBase.so {@rpath/_libBornAgainBase.so}

After:

  + [rel@rpath]: /Users/qtisas/builds/wQZpNRfzw/0/mlz/bornagain/build/lib/_libBornAgainBase.so {@rpath/_libBornAgainBase.so}
...
  + [rel@rpath]: <PKG-ROOT>/lib/extra/libcerf.2.4.dylib {@rpath/libcerf.2.dylib}

The bug disappears if the code that was formerly in function make_python_wheel is put inside a block.

Unfortunately, CMake's block() ... endblock() construct was only introduced in 3.25.

Therefore I'll look for another solution. Otherwise we would have to install CMake from source when building under oldstable.

mentioned in commit a0be0949

mentioned in commit ad8f25b7

mentioned in commit 81efea58

closed with merge request !2498 (merged)

Mac package broken by recent refactoring (install_name_tool complains about duplicate libraries)

Designs

Child items ...

Activity