From f086f5767daec8be2eca305cbc16109a26ccf75f Mon Sep 17 00:00:00 2001
From: Joachim Wuttke <j.wuttke@fz-juelich.de>
Date: Fri, 9 Feb 2024 18:50:38 +0100
Subject: [PATCH] replace 'insertDatafileItem' by 'appendDatafileItem'
---
GUI/Model/Files/DatafilesQModel.cpp | 2 +-
GUI/Model/Files/DatafilesSet.cpp | 2 +-
GUI/Model/Files/DatafilesSet.h | 2 +-
Tests/Unit/GUI/TestDatafilesModel.cpp | 8 ++++----
Tests/Unit/GUI/Utils.cpp | 4 ++--
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/GUI/Model/Files/DatafilesQModel.cpp b/GUI/Model/Files/DatafilesQModel.cpp
index fa059e4c4b2..6d1b1fee47b 100644
--- a/GUI/Model/Files/DatafilesQModel.cpp
+++ b/GUI/Model/Files/DatafilesQModel.cpp
@@ -35,7 +35,7 @@ bool DatafilesQModel::setData(const QModelIndex& index, const QVariant& value, i
void DatafilesQModel::injectDatafileItem(DatafileItem* item)
{
- m_model->insertDatafileItem(item);
+ m_model->appendDatafileItem(item);
const int row = m_model->dfileItems().indexOf(item);
beginInsertRows(indexOfHeadline(), row, row);
m_items = m_model->dfileItems();
diff --git a/GUI/Model/Files/DatafilesSet.cpp b/GUI/Model/Files/DatafilesSet.cpp
index 37016c90bf7..a2076586129 100644
--- a/GUI/Model/Files/DatafilesSet.cpp
+++ b/GUI/Model/Files/DatafilesSet.cpp
@@ -33,7 +33,7 @@ DatafilesSet::DatafilesSet()
DatafilesSet::~DatafilesSet() = default;
-void DatafilesSet::insertDatafileItem(DatafileItem* dfi)
+void DatafilesSet::appendDatafileItem(DatafileItem* dfi)
{
m_dfile_items.emplace_back(dfi);
}
diff --git a/GUI/Model/Files/DatafilesSet.h b/GUI/Model/Files/DatafilesSet.h
index 147748c8ce1..d6a5ae02fe2 100644
--- a/GUI/Model/Files/DatafilesSet.h
+++ b/GUI/Model/Files/DatafilesSet.h
@@ -31,7 +31,7 @@ public:
explicit DatafilesSet();
~DatafilesSet();
- void insertDatafileItem(DatafileItem* dfi);
+ void appendDatafileItem(DatafileItem* dfi);
void removeDatafileItem(DatafileItem* dfi);
void clear();
void readFrom(QXmlStreamReader* r);
diff --git a/Tests/Unit/GUI/TestDatafilesModel.cpp b/Tests/Unit/GUI/TestDatafilesModel.cpp
index 3bf1ddabd56..57d8b28d21f 100644
--- a/Tests/Unit/GUI/TestDatafilesModel.cpp
+++ b/Tests/Unit/GUI/TestDatafilesModel.cpp
@@ -83,18 +83,18 @@ TEST(TestDatafilesSet, saveXMLData)
// add specular DatafileItems with non-default parameters
auto* spec1 = new DatafileItem("spec1", df1);
- model1.insertDatafileItem(spec1);
+ model1.appendDatafileItem(spec1);
spec1->linkToInstrument(instrument_model.addInstrumentItem<SpecularInstrumentItem>());
// add second specular DatafileItem
auto* spec2 = new DatafileItem("spec2", df2);
- model1.insertDatafileItem(spec2);
+ model1.appendDatafileItem(spec2);
// add 2D DatafileItems with non-default parameters
auto* intensity1 = new DatafileItem("GISAS", df2);
auto* intensity2 = new DatafileItem("Offspec", df2);
- model1.insertDatafileItem(intensity1);
- model1.insertDatafileItem(intensity2);
+ model1.appendDatafileItem(intensity1);
+ model1.appendDatafileItem(intensity2);
intensity1->linkToInstrument(instrument_model.addInstrumentItem<GISASInstrumentItem>());
intensity2->linkToInstrument(instrument_model.addInstrumentItem<OffspecInstrumentItem>());
diff --git a/Tests/Unit/GUI/Utils.cpp b/Tests/Unit/GUI/Utils.cpp
index 7c91a191041..9b382b174b5 100644
--- a/Tests/Unit/GUI/Utils.cpp
+++ b/Tests/Unit/GUI/Utils.cpp
@@ -57,14 +57,14 @@ Datafield UTest::GUI::makeData2D(double value, int nx, double x_min, double x_ma
DatafileItem* UTest::GUI::createRealData1D(const QString& name, DatafilesSet& model, double value)
{
auto* dfi = new DatafileItem(name, makeData1D(value));
- model.insertDatafileItem(dfi);
+ model.appendDatafileItem(dfi);
return dfi;
}
DatafileItem* UTest::GUI::createRealData2D(const QString& name, DatafilesSet& model, double value)
{
auto* dfi = new DatafileItem(name, makeData2D(value));
- model.insertDatafileItem(dfi);
+ model.appendDatafileItem(dfi);
return dfi;
}
--
GitLab