cleanup

GUI/Model/Data/DataItem.cpp

@@ -23,7 +23,7 @@ void DataItem::setDatafield(Datafield* data)
     m_data.reset(data);
 
     setLastModified(QDateTime::currentDateTime());
-    emit datafieldChanged(data);
+    emit datafieldChanged();
 #ifdef USE_MAPPERS
     emitDataChanged();
 #endif

GUI/Model/Data/DataItem.h

@@ -76,7 +76,7 @@ public:
     virtual void reset(ImportDataInfo data) = 0;
 
 signals:
-    void datafieldChanged(Datafield* data);
+    void datafieldChanged();
     void rawDataVectorChanged(const std::vector<double>& data);
     void fileNameChanged(const QString& filename);
     void axesUnitsChanged();

GUI/View/PlotComparison/FitComparisonController.cpp

@@ -177,7 +177,7 @@ void DiffItemController::subscribe()
     m_current_item->dataItem()->mapper()->setOnValueChange([this]() { updateDiffData(); }, this);
 #else
     connect(m_current_item->dataItem(), &DataItem::datafieldChanged, this,
-            [=](Datafield*) { updateDiffData(); });
+            &DiffItemController::updateDiffData, Qt::UniqueConnection);
 #endif
 
     // on diff item units change

GUI/View/PlotComparison/FitComparisonViewController.cpp

@@ -168,7 +168,7 @@ void DiffItemController::subscribe()
     m_current_item->dataItem()->mapper()->setOnValueChange([this]() { updateDiffData(); }, this);
 #else
     connect(m_current_item->dataItem(), &DataItem::datafieldChanged, this,
-            [=](Datafield*) { updateDiffData(); });
+            &DiffItemController::updateDiffData, Qt::UniqueConnection);
 #endif
 }
 

GUI/View/PlotComparison/Plot1D.cpp

@@ -134,7 +134,7 @@ void Plot1D::subscribeToItem()
 #else
         DataItem* dataItem = pair.first->dataItem();
         connect(dataItem, &DataItem::datafieldChanged, caller,
-                [caller](Datafield*) { caller->refreshPlotData(); });
+                [caller]() { caller->refreshPlotData(); });
 #endif
     });
     setConnected(true);

GUI/View/PlotUtil/ColorMap.cpp

@@ -225,9 +225,8 @@ void ColorMap::subscribeToItem()
     intensityItem()->mapper()->setOnValueChange([this]() { onIntensityModified(); }, this);
 #else
     // datafield
-    connect(intensityItem(), &IntensityDataItem::datafieldChanged, this, [=]() {
-            onIntensityModified();
-    });
+    connect(intensityItem(), &IntensityDataItem::datafieldChanged, this,
+            &ColorMap::onIntensityModified, Qt::UniqueConnection);
     // units
     connect(intensityItem(), &IntensityDataItem::axesUnitsReplotRequested, this, [=]() {
             setAxesRangeFromItem(intensityItem());

GUI/View/Projection/ProjectionsPlot.cpp

@@ -120,7 +120,6 @@ void ProjectionsPlot::subscribeToItem()
             &ProjectionsPlot::updateAxesRange, Qt::UniqueConnection);
 
     // if axes are changed externally, from the properties panel:
-
     // axes range
     connect(intensityItem()->xAxisItem(), &BasicAxisItem::axisRangeChanged, this,
             &ProjectionsPlot::updateAxesRange, Qt::UniqueConnection);