From a0b99749712426595941cd43d1fd93569a6bb2d0 Mon Sep 17 00:00:00 2001
From: "Joachim Wuttke (h)" <j.wuttke@fz-juelich.de>
Date: Wed, 25 May 2022 13:41:53 +0200
Subject: [PATCH] no need for double negation with unique_ptr
---
Device/Mask/DetectorMask.cpp | 2 +-
Sim/Scan/AlphaScan.cpp | 4 ++--
Sim/Scan/QzScan.cpp | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Device/Mask/DetectorMask.cpp b/Device/Mask/DetectorMask.cpp
index 9cd83470629..057a76e1fa3 100644
--- a/Device/Mask/DetectorMask.cpp
+++ b/Device/Mask/DetectorMask.cpp
@@ -105,7 +105,7 @@ const MaskPattern* DetectorMask::patternAt(size_t iMask) const
void DetectorMask::process_masks()
{
m_masked->setAllTo(false);
- if (!!m_stack.empty())
+ if (m_stack.empty())
return;
m_number_of_masked_channels = 0;
diff --git a/Sim/Scan/AlphaScan.cpp b/Sim/Scan/AlphaScan.cpp
index bdd3d879d24..eeaa82a4e70 100644
--- a/Sim/Scan/AlphaScan.cpp
+++ b/Sim/Scan/AlphaScan.cpp
@@ -89,9 +89,9 @@ AlphaScan::~AlphaScan() = default;
std::vector<SpecularElement> AlphaScan::generateElements(PolMatrices polpair) const
{
- if (!!m_beamPolarization)
+ if (m_beamPolarization)
polpair.setPolarizerMatrix(SpinMatrix::FromBlochVector(*m_beamPolarization));
- if (!!m_polAnalyzer)
+ if (m_polAnalyzer)
polpair.setAnalyzerMatrix(m_polAnalyzer->matrix());
const auto wls = extractValues(applyWlResolution(),
diff --git a/Sim/Scan/QzScan.cpp b/Sim/Scan/QzScan.cpp
index 716466a72b5..f4bdab964c7 100644
--- a/Sim/Scan/QzScan.cpp
+++ b/Sim/Scan/QzScan.cpp
@@ -61,9 +61,9 @@ QzScan* QzScan::clone() const
//! Generates simulation elements for specular simulations
std::vector<SpecularElement> QzScan::generateElements(PolMatrices polpair) const
{
- if (!!m_beamPolarization)
+ if (m_beamPolarization)
polpair.setPolarizerMatrix(SpinMatrix::FromBlochVector(*m_beamPolarization));
- if (!!m_polAnalyzer)
+ if (m_polAnalyzer)
polpair.setAnalyzerMatrix(m_polAnalyzer->matrix());
const std::vector<double> qz = generateQzVector();
--
GitLab