From 9a54db81f90a2bc63ea9cc5402a4b096cb2c6ae6 Mon Sep 17 00:00:00 2001
From: Joachim Wuttke <j.wuttke@fz-juelich.de>
Date: Wed, 29 Nov 2023 14:56:09 +0100
Subject: [PATCH] recommended by clang-tidy
---
GUI/View/Numeric/NumWidgetUtil.cpp | 6 +++---
GUI/View/ParEdit/FitParameterDelegate.cpp | 4 ++--
GUI/View/Plotter/ColorMap.cpp | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/GUI/View/Numeric/NumWidgetUtil.cpp b/GUI/View/Numeric/NumWidgetUtil.cpp
index 1e75ab49d77..f69ab4abcfc 100644
--- a/GUI/View/Numeric/NumWidgetUtil.cpp
+++ b/GUI/View/Numeric/NumWidgetUtil.cpp
@@ -47,7 +47,7 @@ ScientificSpinBox* GUI::Util::createScientificSpinBox(QFormLayout* parentLayout,
QCheckBox* GUI::Util::createCheckBox(const QString& title, function<bool()> getter,
function<void(bool)> setter, QList<function<void()>>* updaters)
{
- QCheckBox* checkBox = new QCheckBox(title);
+ auto* checkBox = new QCheckBox(title);
checkBox->setChecked(getter());
QObject::connect(checkBox, &QCheckBox::stateChanged, [=]() { setter(checkBox->isChecked()); });
@@ -65,7 +65,7 @@ QSpinBox* GUI::Util::createIntSpinbox(function<int()> getter, function<void(int)
const RealLimits& limits, QString tooltip,
QList<function<void()>>* updaters, bool easyScrollable)
{
- QSpinBox* spin = new QSpinBox;
+ auto* spin = new QSpinBox;
spin->setFocusPolicy(Qt::StrongFocus);
spin->setMinimum(limits.hasLowerLimit() ? limits.lowerLimit()
@@ -94,7 +94,7 @@ QDoubleSpinBox* GUI::Util::createDoubleSpinbox(function<double()> getter,
QList<function<void()>>* updaters, QString tooltip,
const RealLimits& limits, bool easyScrollable)
{
- QDoubleSpinBox* spin = new QDoubleSpinBox;
+ auto* spin = new QDoubleSpinBox;
spin->setFocusPolicy(Qt::StrongFocus);
spin->setMinimum(limits.hasLowerLimit() ? limits.lowerLimit()
: -std::numeric_limits<int>::max());
diff --git a/GUI/View/ParEdit/FitParameterDelegate.cpp b/GUI/View/ParEdit/FitParameterDelegate.cpp
index dcb95f50cd4..ce6a467e96a 100644
--- a/GUI/View/ParEdit/FitParameterDelegate.cpp
+++ b/GUI/View/ParEdit/FitParameterDelegate.cpp
@@ -60,7 +60,7 @@ QString toString(const QModelIndex& index)
if (isDoubleProperty(variant) && index.internalPointer()) {
auto* item = static_cast<QObject*>(index.internalPointer());
- FitDoubleItem* doubleItem = dynamic_cast<FitDoubleItem*>(item);
+ auto* doubleItem = dynamic_cast<FitDoubleItem*>(item);
// only "Scientific SpinBoxes" in Fit-Window
return ScientificSpinBox::toString(doubleItem->value(), doubleItem->decimals());
}
@@ -71,7 +71,7 @@ QWidget* createEditor(QObject* item, QWidget* parent)
{
CustomEditor* result(nullptr);
- if (FitDoubleItem* doubleItem = dynamic_cast<FitDoubleItem*>(item)) {
+ if (auto* doubleItem = dynamic_cast<FitDoubleItem*>(item)) {
// only Scientific SpinBoxes in Fit-Window
auto* editor = new ScientificSpinBoxEditor;
editor->setLimits(doubleItem->limits());
diff --git a/GUI/View/Plotter/ColorMap.cpp b/GUI/View/Plotter/ColorMap.cpp
index 63dbc0cad1d..67ad99c1f3f 100644
--- a/GUI/View/Plotter/ColorMap.cpp
+++ b/GUI/View/Plotter/ColorMap.cpp
@@ -35,7 +35,7 @@ const int colorbar_width = 80;
QCPRange qcpRange(double xmin, double xmax, int nbins)
{
double dx = (xmax - xmin) / nbins;
- return QCPRange(xmin + dx / 2., xmax - dx / 2.);
+ return {xmin + dx / 2., xmax - dx / 2.};
}
} // namespace
--
GitLab