From 6826c6450ed7b646951974e0ee02ec5e4afda306 Mon Sep 17 00:00:00 2001
From: "Joachim Wuttke (h)" <j.wuttke@fz-juelich.de>
Date: Thu, 11 Nov 2021 23:45:04 +0100
Subject: [PATCH] corr
---
.clang-tidy | 5 ++++-
Device/Mask/Polygon.cpp | 4 ++--
auto/Wrap/doxygenDevice.i | 2 +-
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/.clang-tidy b/.clang-tidy
index bda8e8d62e9..0fa3334dd3b 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -97,6 +97,7 @@ Checks: '*,
-*use-auto,
-*move-const-arg,
+-*use-equals-default,
-*use-nullptr,
-*use-override,
-bugprone-parent-virtual-call,
@@ -112,6 +113,7 @@ Checks: '*,
-hicpp-noexcept-move,
-llvm-qualified-auto,
-misc-non-private-member-variables-in-classes,
+-misc-uniqueptr-reset-release,
-modernize-loop-convert,
-modernize-make-unique,
-modernize-pass-by-value,
@@ -120,11 +122,12 @@ Checks: '*,
-modernize-use-using,
-performance-for-range-copy,
-readability-avoid-const-params-in-decls,
+-readability-const-return-type,
+-readability-non-const-parameter,
-readability-container-size-empty,
-readability-delete-null-pointer,
-readability-inconsistent-declaration-parameter-name,
-readability-qualified-auto,
--readability-const-return-type,
-readability-redundant-member-init,
-readability-simplify-boolean-expr,
diff --git a/Device/Mask/Polygon.cpp b/Device/Mask/Polygon.cpp
index f5e6c6307fd..0208defd118 100644
--- a/Device/Mask/Polygon.cpp
+++ b/Device/Mask/Polygon.cpp
@@ -24,7 +24,7 @@ public:
using polygon_t = boost::geometry::model::polygon<point_t>;
polygon_t polygon;
void init_from(const std::vector<double>& x, const std::vector<double>& y);
- void get_points(const std::vector<double>& xpos, const std::vector<double>& ypos);
+ void get_points(std::vector<double>& xpos, std::vector<double>& ypos); // TODO const or no-&
};
void PolygonPrivate::init_from(const std::vector<double>& x, const std::vector<double>& y)
@@ -40,7 +40,7 @@ void PolygonPrivate::init_from(const std::vector<double>& x, const std::vector<d
boost::geometry::correct(polygon);
}
-void PolygonPrivate::get_points(const std::vector<double>& xpos, const std::vector<double>& ypos)
+void PolygonPrivate::get_points(std::vector<double>& xpos, std::vector<double>& ypos)
{
xpos.clear();
ypos.clear();
diff --git a/auto/Wrap/doxygenDevice.i b/auto/Wrap/doxygenDevice.i
index 7a90f24fa69..c5cf80c76b0 100644
--- a/auto/Wrap/doxygenDevice.i
+++ b/auto/Wrap/doxygenDevice.i
@@ -2261,7 +2261,7 @@ The private data for polygons to hide boost dependency from the header.
%feature("docstring") PolygonPrivate::init_from "void PolygonPrivate::init_from(const std::vector< double > &x, const std::vector< double > &y)
";
-%feature("docstring") PolygonPrivate::get_points "void PolygonPrivate::get_points(std::vector< double > &xpos, std::vector< double > &ypos)
+%feature("docstring") PolygonPrivate::get_points "void PolygonPrivate::get_points(const std::vector< double > &xpos, const std::vector< double > &ypos)
";
--
GitLab