diff --git a/GUI/Util/DeserializationException.cpp b/GUI/Util/DeserializationException.cpp index fab575a53f0fb05c8ca0bf3322f8b955d1951759..6f072673ded1f698c391676fa63013edde5e8fa5 100644 --- a/GUI/Util/DeserializationException.cpp +++ b/GUI/Util/DeserializationException.cpp @@ -14,8 +14,9 @@ #include "GUI/Util/DeserializationException.h" #include <QString> +#include <utility> -DeserializationException::DeserializationException(const QString& t) : m_text(t) {} +DeserializationException::DeserializationException(QString t) : m_text(std::move(t)) {} DeserializationException DeserializationException::tooOld() { diff --git a/GUI/Util/DeserializationException.h b/GUI/Util/DeserializationException.h index f55df8f36a261aba365782968ee6df81f6b73632..6b8bbd09c17b71d4557ca275e8ebb2ab2adbd727 100644 --- a/GUI/Util/DeserializationException.h +++ b/GUI/Util/DeserializationException.h @@ -19,7 +19,7 @@ class DeserializationException { private: - DeserializationException(const QString& t); + DeserializationException(QString t); public: static DeserializationException tooOld(); diff --git a/GUI/Util/MessageService.h b/GUI/Util/MessageService.h index 11df280cb884aa1036fe8c88c0fb26150daafcc5..e12765d247677936cf34a948d87ba1a303dba1ae 100644 --- a/GUI/Util/MessageService.h +++ b/GUI/Util/MessageService.h @@ -33,7 +33,7 @@ public: QStringList warnings(bool includeSenders = false) const; private: - typedef QList<QPair<QString, QString>> Messages; // pair of sender & description + using Messages = QList<QPair<QString, QString>>; // pair of sender & description QStringList descriptions(const Messages& messages, bool includeSenders) const; diff --git a/GUI/ba3d/widget.h b/GUI/ba3d/widget.h index e0be1511c7f9303771b4bd97d6b1d85fe1ebcd49..2bc67de9c86d3ff6962c6cf73a6b8608ebed3cbb 100644 --- a/GUI/ba3d/widget.h +++ b/GUI/ba3d/widget.h @@ -29,7 +29,7 @@ class Widget3D : public QWidget { Q_OBJECT public: Widget3D(); - ~Widget3D(); + ~Widget3D() override; Camera& cam();