diff --git a/GUI/Models/Data/IntensityDataItem.cpp b/GUI/Models/Data/IntensityDataItem.cpp index 9264114dd31f44ad075ae6281cb517b8b5cc9059..5bcf51dd9f46b55ca7ae20623e28c6faf1d5c64e 100644 --- a/GUI/Models/Data/IntensityDataItem.cpp +++ b/GUI/Models/Data/IntensityDataItem.cpp @@ -16,10 +16,10 @@ #include "GUI/Models/Data/AxesItems.h" #include "GUI/Models/Data/ImportDataInfo.h" #include "GUI/Models/Data/MaskUnitsConverter.h" +#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Models/Job/JobItemUtils.h" #include "GUI/Models/Session/SessionModel.h" -#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/utils/Error.h" namespace { diff --git a/GUI/Models/Data/MaskUnitsConverter.cpp b/GUI/Models/Data/MaskUnitsConverter.cpp index 3fcbfe96f97eeec64ce58a6f00fb0f5a7316d4dd..07b63a98bf0400cbcfccb803e1b77610ad8bc536 100644 --- a/GUI/Models/Data/MaskUnitsConverter.cpp +++ b/GUI/Models/Data/MaskUnitsConverter.cpp @@ -15,8 +15,8 @@ #include "GUI/Models/Data/MaskUnitsConverter.h" #include "Device/Data/DataUtils.h" #include "GUI/Models/Data/IntensityDataItem.h" -#include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Models/Data/ProjectionItems.h" +#include "GUI/Models/Instrument/MaskItems.h" #include <boost/polymorphic_cast.hpp> using boost::polymorphic_downcast; diff --git a/GUI/Models/Data/RealDataItem.cpp b/GUI/Models/Data/RealDataItem.cpp index e72946856d27832aca252a5a0e7d1c7aff89b2bf..fe70d7369fde0de798b40004201eb8d7ae5b06d9 100644 --- a/GUI/Models/Data/RealDataItem.cpp +++ b/GUI/Models/Data/RealDataItem.cpp @@ -19,6 +19,7 @@ #include "GUI/Models/Data/DataLoaders1D.h" #include "GUI/Models/Data/ImportDataInfo.h" #include "GUI/Models/Data/IntensityDataItem.h" +#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/Models/Data/RealDataModel.h" #include "GUI/Models/Data/SpecularDataItem.h" #include "GUI/Models/Instrument/InstrumentItems.h" @@ -27,11 +28,10 @@ #include "GUI/Models/Job/JobItem.h" #include "GUI/Models/Job/JobItemUtils.h" #include "GUI/Models/Job/JobModelFunctions.h" -#include "GUI/Models/Data/ProjectionItems.h" -#include "GUI/Models/Varia/ItemFileNameUtils.h" #include "GUI/Session/SessionData.h" #include "GUI/utils/DeserializationException.h" #include "GUI/utils/Error.h" +#include "GUI/utils/ItemFileNameUtils.h" #include <QtCore/QXmlStreamReader> #include <QtCore/QXmlStreamWriter> diff --git a/GUI/Models/Fit/FitParameterHelper.cpp b/GUI/Models/Fit/FitParameterHelper.cpp index 6eea751ef8241a8c3b9738d73996a1fe4169531f..21f5b409b264b4767f8f1a7445069eb62768b172 100644 --- a/GUI/Models/Fit/FitParameterHelper.cpp +++ b/GUI/Models/Fit/FitParameterHelper.cpp @@ -14,9 +14,9 @@ #include "GUI/Models/Fit/FitParameterHelper.h" #include "GUI/Models/Fit/FitParameterItems.h" +#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Job/JobItem.h" #include "GUI/Models/Job/JobModel.h" -#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Session/ModelPath.h" //! Creates fit parameter from given ParameterItem, sets starting value to the value diff --git a/GUI/Models/Fit/FitParameterItems.cpp b/GUI/Models/Fit/FitParameterItems.cpp index dc6d982ecd5442aebc449e3792e980bf4bac252b..5e05f4a412984e73ae09253cb87d318a528e698e 100644 --- a/GUI/Models/Fit/FitParameterItems.cpp +++ b/GUI/Models/Fit/FitParameterItems.cpp @@ -15,9 +15,9 @@ #include "GUI/Models/Fit/FitParameterItems.h" #include "Base/Utils/Assert.h" #include "Fit/Param/Parameters.h" +#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Group/ComboProperty.h" #include "GUI/Models/Job/JobItem.h" -#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Session/ModelPath.h" #include "GUI/utils/Error.h" #include <cmath> diff --git a/GUI/Models/Instrument/InstrumentItems.cpp b/GUI/Models/Instrument/InstrumentItems.cpp index ef62799576851fcc8cfb92ef90bdcd80cd504c6c..9ef52a4f3c310887a09f1b7b029cdcceb412f3fa 100644 --- a/GUI/Models/Instrument/InstrumentItems.cpp +++ b/GUI/Models/Instrument/InstrumentItems.cpp @@ -32,9 +32,9 @@ #include "GUI/Models/Instrument/SphericalDetectorItem.h" #include "GUI/Models/Job/JobItemUtils.h" #include "GUI/Models/Types/VectorItem.h" -#include "GUI/Models/Varia/ItemFileNameUtils.h" #include "GUI/utils/Error.h" #include "GUI/utils/Helpers.h" +#include "GUI/utils/ItemFileNameUtils.h" namespace { @@ -231,7 +231,7 @@ SpecularInstrumentItem::SpecularInstrumentItem() : InstrumentItem(M_TYPE) initBackgroundGroup(); beam<SpecularBeamItem>()->updateFileName( - GUI::Model::FilenameUtils::instrumentDataFileName(*this)); + GUI::Model::FilenameUtils::instrumentDataFileName(id())); } SpecularBeamItem* SpecularInstrumentItem::beamItem() const diff --git a/GUI/Models/Job/JobItem.cpp b/GUI/Models/Job/JobItem.cpp index dda6863069ed2a8252969e36b933a9acc53731cd..19a8b953948d55ed3ffb019f043de38f100ec035 100644 --- a/GUI/Models/Job/JobItem.cpp +++ b/GUI/Models/Job/JobItem.cpp @@ -19,14 +19,14 @@ #include "GUI/Models/Data/RealDataItem.h" #include "GUI/Models/Data/SpecularDataItem.h" #include "GUI/Models/Fit/FitSuiteItem.h" +#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Instrument/InstrumentItems.h" #include "GUI/Models/Job/JobItemUtils.h" #include "GUI/Models/Material/MaterialItemContainer.h" -#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Sample/MultiLayerItem.h" -#include "GUI/Models/Varia/ItemFileNameUtils.h" #include "GUI/Models/Varia/SimulationOptionsItem.h" #include "GUI/utils/Error.h" +#include "GUI/utils/ItemFileNameUtils.h" JobItem::JobItem() : SessionItem(M_TYPE) { @@ -383,14 +383,14 @@ void JobItem::setPresentationType(const QString& type) void JobItem::updateIntensityDataFileName() { if (DataItem* item = dataItem()) - item->setFileName(GUI::Model::FilenameUtils::jobResultsFileName(*this)); + item->setFileName(GUI::Model::FilenameUtils::jobResultsFileName(itemName())); if (RealDataItem* realItem = realDataItem()) { if (DataItem* item = realItem->dataItem()) - item->setFileName(GUI::Model::FilenameUtils::jobReferenceFileName(*this)); + item->setFileName(GUI::Model::FilenameUtils::jobReferenceFileName(itemName())); if (DataItem* item = realItem->nativeData()) - item->setFileName(GUI::Model::FilenameUtils::jobNativeDataFileName(*this)); + item->setFileName(GUI::Model::FilenameUtils::jobNativeDataFileName(getIdentifier())); } } diff --git a/GUI/Models/Job/JobModel.cpp b/GUI/Models/Job/JobModel.cpp index 735951f5a24b6f12f369c9a20c8324b130c0e941..8d084a1534d3989a12870f585f27268145e217f3 100644 --- a/GUI/Models/Job/JobModel.cpp +++ b/GUI/Models/Job/JobModel.cpp @@ -16,13 +16,13 @@ #include "GUI/Models/Data/IntensityDataItem.h" #include "GUI/Models/Data/PointwiseAxisItem.h" #include "GUI/Models/Data/RealDataItem.h" +#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Group/GroupItem.h" #include "GUI/Models/Instrument/InstrumentItems.h" #include "GUI/Models/Job/JobItem.h" #include "GUI/Models/Job/JobModelFunctions.h" #include "GUI/Models/Job/JobQueueData.h" #include "GUI/Models/Job/ParameterTreeUtils.h" -#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Sample/MultiLayerItem.h" #include "GUI/utils/Helpers.h" diff --git a/GUI/Models/Job/JobModelFunctions.cpp b/GUI/Models/Job/JobModelFunctions.cpp index 251436cafd571f1c8c119ca66e435e9183f97930..110cdb959c1b5fe8a231290668f4211e5d828094 100644 --- a/GUI/Models/Job/JobModelFunctions.cpp +++ b/GUI/Models/Job/JobModelFunctions.cpp @@ -31,10 +31,10 @@ #include "GUI/Models/Material/MaterialItemContainer.h" #include "GUI/Models/Material/MaterialItemUtils.h" #include "GUI/Models/Sample/MultiLayerItem.h" -#include "GUI/Models/Varia/ItemFileNameUtils.h" #include "GUI/Models/Varia/ItemWithMaterial.h" #include "GUI/utils/Error.h" #include "GUI/utils/Helpers.h" +#include "GUI/utils/ItemFileNameUtils.h" #include <map> namespace { @@ -160,7 +160,7 @@ void GUI::Model::JobFunctions::setupJobItemInstrument(JobItem* jobItem, const In return; // updating filename - const auto filename = GUI::Model::FilenameUtils::instrumentDataFileName(*spec_to); + const auto filename = GUI::Model::FilenameUtils::instrumentDataFileName(spec_to->id()); spec_to->beamItem()->updateFileName(filename); // copying axis data @@ -233,7 +233,7 @@ void GUI::Model::JobFunctions::copyRealDataItem(JobItem* jobItem, const RealData // adapting the name to job name realDataItemCopy->dataItem()->setFileName( - GUI::Model::FilenameUtils::jobReferenceFileName(*jobItem)); + GUI::Model::FilenameUtils::jobReferenceFileName(jobItem->itemName())); // #baimport ++ copy members of realDataItem? @@ -242,7 +242,7 @@ void GUI::Model::JobFunctions::copyRealDataItem(JobItem* jobItem, const RealData realDataItemCopy->setNativeOutputData(realDataItem->nativeOutputData()->clone()); realDataItemCopy->nativeData()->setFileName( - GUI::Model::FilenameUtils::jobNativeDataFileName(*jobItem)); + GUI::Model::FilenameUtils::jobNativeDataFileName(jobItem->getIdentifier())); } const JobItem* GUI::Model::JobFunctions::findJobItem(const SessionItem* item) diff --git a/GUI/Models/Job/ParameterTreeUtils.cpp b/GUI/Models/Job/ParameterTreeUtils.cpp index 0535ee4a225cfb7b86de7cda845b9481764d79f9..40f9e7ee9f6994e9567a32caae245117e76c5a25 100644 --- a/GUI/Models/Job/ParameterTreeUtils.cpp +++ b/GUI/Models/Job/ParameterTreeUtils.cpp @@ -13,11 +13,11 @@ // ************************************************************************************************ #include "GUI/Models/Job/ParameterTreeUtils.h" +#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Group/GroupItem.h" #include "GUI/Models/Instrument/InstrumentItems.h" #include "GUI/Models/Job/JobItem.h" #include "GUI/Models/Material/MaterialItemContainer.h" -#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Parameter/PropertyItem.h" #include "GUI/Models/Sample/MultiLayerItem.h" #include "GUI/Models/Session/ModelPath.h" diff --git a/GUI/Models/Session/SessionItem.cpp b/GUI/Models/Session/SessionItem.cpp index db36d6b0dfb6e36cfcd1cf3df76d0a198eababa3..90cbdd28f8514316d667da445efe1c0b6d688c9f 100644 --- a/GUI/Models/Session/SessionItem.cpp +++ b/GUI/Models/Session/SessionItem.cpp @@ -12,8 +12,8 @@ // // ************************************************************************************************ -#include "GUI/Models/Group/GroupItem.h" #include "GUI/Models/Fit/ParameterTreeItems.h" +#include "GUI/Models/Group/GroupItem.h" #include "GUI/Models/Parameter/PropertyItem.h" #include "GUI/Models/Session/SessionItemData.h" #include "GUI/Models/Session/SessionItemTags.h" diff --git a/GUI/Models/Varia/ItemCatalog.cpp b/GUI/Models/Varia/ItemCatalog.cpp index a03e2a92a941f7d35318fc3080bb2de4ac78442d..cc82c8aabbc6803dfde4b5c20266d45b2cc2521b 100644 --- a/GUI/Models/Varia/ItemCatalog.cpp +++ b/GUI/Models/Varia/ItemCatalog.cpp @@ -19,11 +19,13 @@ #include "GUI/Models/Data/DataPropertyContainer.h" #include "GUI/Models/Data/IntensityDataItem.h" #include "GUI/Models/Data/PointwiseAxisItem.h" +#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/Models/Data/RealDataItem.h" #include "GUI/Models/Data/SpecularDataItem.h" #include "GUI/Models/Fit/FitParameterItems.h" #include "GUI/Models/Fit/FitSuiteItem.h" #include "GUI/Models/Fit/MinimizerItem.h" +#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Group/GroupItem.h" #include "GUI/Models/Instrument/BackgroundItems.h" #include "GUI/Models/Instrument/BeamAngleItems.h" @@ -38,7 +40,6 @@ #include "GUI/Models/Material/MaterialDataItems.h" #include "GUI/Models/Material/MaterialItem.h" #include "GUI/Models/Material/MaterialItemContainer.h" -#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Parameter/PropertyItem.h" #include "GUI/Models/Sample/FTDecayFunctionItems.h" #include "GUI/Models/Sample/FTDistributionItems.h" @@ -54,7 +55,6 @@ #include "GUI/Models/Sample/ParticleItem.h" #include "GUI/Models/Sample/ParticleLayoutItem.h" #include "GUI/Models/Sample/ResolutionFunctionItems.h" -#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/Models/Trafo/RotationItems.h" #include "GUI/Models/Trafo/TransformationItem.h" #include "GUI/Models/Types/VectorItem.h" diff --git a/GUI/Views/FitWidgets/FitParameterWidget.cpp b/GUI/Views/FitWidgets/FitParameterWidget.cpp index c05178960f0497d13d99f572cd9c9516654500ca..40ae6ab05a9f23986f994dc125446bc2404c3507 100644 --- a/GUI/Views/FitWidgets/FitParameterWidget.cpp +++ b/GUI/Views/FitWidgets/FitParameterWidget.cpp @@ -17,10 +17,10 @@ #include "GUI/Models/Fit/FitParameterItems.h" #include "GUI/Models/Fit/FitParameterProxyModel.h" #include "GUI/Models/Fit/FitSuiteItem.h" +#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Job/JobItem.h" #include "GUI/Models/Job/JobModel.h" #include "GUI/Models/Parameter/FilterPropertyProxy.h" -#include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Views/FitWidgets/ParameterTuningWidget.h" #include "GUI/Views/PropertyEditor/SessionModelDelegate.h" #include "GUI/Widgets/Info/OverlayLabelController.h" diff --git a/GUI/Views/FitWidgets/ParameterTuningWidget.cpp b/GUI/Views/FitWidgets/ParameterTuningWidget.cpp index db102ce55ac810040a3a4bed3a770904262c672f..84e5900e1acdada30e3a6671184c978dcb7921ca 100644 --- a/GUI/Views/FitWidgets/ParameterTuningWidget.cpp +++ b/GUI/Views/FitWidgets/ParameterTuningWidget.cpp @@ -14,10 +14,10 @@ #include "GUI/Views/FitWidgets/ParameterTuningWidget.h" #include "GUI/Models/Data/IntensityDataItem.h" -#include "GUI/Models/Job/JobItem.h" -#include "GUI/Models/Job/JobModel.h" #include "GUI/Models/Fit/ParameterTreeItems.h" #include "GUI/Models/Fit/ParameterTuningModel.h" +#include "GUI/Models/Job/JobItem.h" +#include "GUI/Models/Job/JobModel.h" #include "GUI/Views/FitWidgets/JobRealTimeToolBar.h" #include "GUI/Views/FitWidgets/ParameterTuningDelegate.h" #include "GUI/Views/FitWidgets/SliderSettingsWidget.h" diff --git a/GUI/Views/MaskWidgets/MaskContainerView.cpp b/GUI/Views/MaskWidgets/MaskContainerView.cpp index 8c2f894265f6d5c5ea1d9b26fdd9a734d66c173c..04d178157817e9551b244b63d96049bdf75d1e78 100644 --- a/GUI/Views/MaskWidgets/MaskContainerView.cpp +++ b/GUI/Views/MaskWidgets/MaskContainerView.cpp @@ -13,8 +13,8 @@ // ************************************************************************************************ #include "GUI/Views/MaskWidgets/MaskContainerView.h" -#include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Models/Data/ProjectionItems.h" +#include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Views/MaskWidgets/ISceneAdaptor.h" #include <QBrush> #include <QPainter> diff --git a/GUI/Views/MaskWidgets/MaskGraphicsScene.cpp b/GUI/Views/MaskWidgets/MaskGraphicsScene.cpp index 1cb302d8eac7de04f34c37e00614d00adfda3765..8cb5ea7656a46b48f4dbdbffc7707bd35fff902b 100644 --- a/GUI/Views/MaskWidgets/MaskGraphicsScene.cpp +++ b/GUI/Views/MaskWidgets/MaskGraphicsScene.cpp @@ -13,11 +13,11 @@ // ************************************************************************************************ #include "GUI/Views/MaskWidgets/MaskGraphicsScene.h" +#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/Models/Group/GroupItem.h" #include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Models/Parameter/PropertyItem.h" #include "GUI/Models/Session/SessionModel.h" -#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/Views/MaskWidgets/ColorMapSceneAdaptor.h" #include "GUI/Views/MaskWidgets/MaskGraphicsProxy.h" #include "GUI/Views/MaskWidgets/MaskViewFactory.h" diff --git a/GUI/Views/MaskWidgets/MaskViewFactory.cpp b/GUI/Views/MaskWidgets/MaskViewFactory.cpp index 56ef4e073947ef64d5976f344be1d859179fb06f..16d4f6bb09e616bcf76f6ba86b888a04f245b4a7 100644 --- a/GUI/Views/MaskWidgets/MaskViewFactory.cpp +++ b/GUI/Views/MaskWidgets/MaskViewFactory.cpp @@ -13,9 +13,9 @@ // ************************************************************************************************ #include "GUI/Views/MaskWidgets/MaskViewFactory.h" +#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Models/Session/SessionItem.h" -#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/Views/MaskWidgets/EllipseView.h" #include "GUI/Views/MaskWidgets/LineViews.h" #include "GUI/Views/MaskWidgets/MaskAllView.h" diff --git a/GUI/Views/ProjectionsWidgets/ProjectionsPlot.cpp b/GUI/Views/ProjectionsWidgets/ProjectionsPlot.cpp index 25bf88d389dbcdd536041320f16f07942c0b1403..83b6293aabcbadeddec9be9a5db5314cb844c6fb 100644 --- a/GUI/Views/ProjectionsWidgets/ProjectionsPlot.cpp +++ b/GUI/Views/ProjectionsWidgets/ProjectionsPlot.cpp @@ -17,8 +17,8 @@ #include "Device/Histo/Histogram2D.h" #include "GUI/Models/Data/AxesItems.h" #include "GUI/Models/Data/IntensityDataItem.h" -#include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Models/Data/ProjectionItems.h" +#include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Views/IntensityDataWidgets/ColorMapUtils.h" #include "GUI/Views/IntensityDataWidgets/PlotConstants.h" #include <qcustomplot.h> diff --git a/GUI/Views/ProjectionsWidgets/SaveProjectionsAssistant.cpp b/GUI/Views/ProjectionsWidgets/SaveProjectionsAssistant.cpp index a45ad5b737fc67837a1d01d74aa364d489544704..41489bf44b44ebfe572f179e8bba3178201375ef 100644 --- a/GUI/Views/ProjectionsWidgets/SaveProjectionsAssistant.cpp +++ b/GUI/Views/ProjectionsWidgets/SaveProjectionsAssistant.cpp @@ -18,8 +18,8 @@ #include "Device/Histo/Histogram2D.h" #include "GUI/Application/GlobalSettings.h" #include "GUI/Models/Data/IntensityDataItem.h" -#include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Models/Data/ProjectionItems.h" +#include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Views/Main/ProjectManager.h" #include "GUI/utils/Error.h" #include <QFileDialog> diff --git a/GUI/Models/Varia/ItemFileNameUtils.cpp b/GUI/utils/ItemFileNameUtils.cpp similarity index 75% rename from GUI/Models/Varia/ItemFileNameUtils.cpp rename to GUI/utils/ItemFileNameUtils.cpp index 5e1f3b863998a051f5ccca282e85a75a5f0ec2a9..5f418d154f4bdd945b5e3d10e8ee393eaa35034a 100644 --- a/GUI/Models/Varia/ItemFileNameUtils.cpp +++ b/GUI/utils/ItemFileNameUtils.cpp @@ -2,7 +2,7 @@ // // BornAgain: simulate and fit reflection and scattering // -//! @file GUI/Models/Varia/ItemFileNameUtils.cpp +//! @file GUI/utils/ItemFileNameUtils.cpp //! @brief Defines auxiliary functions in ItemFileNameUtils namespace. //! //! @homepage http://www.bornagainproject.org @@ -12,9 +12,7 @@ // // ************************************************************************************************ -#include "GUI/Models/Varia/ItemFileNameUtils.h" -#include "GUI/Models/Instrument/InstrumentItems.h" -#include "GUI/Models/Job/JobItem.h" +#include "GUI/utils/ItemFileNameUtils.h" #include "GUI/utils/Helpers.h" namespace { @@ -37,21 +35,21 @@ QString intensityDataFileName(const QString& itemName, const QString& prefix) //! Constructs the name of the file with simulated intensities. -QString GUI::Model::FilenameUtils::jobResultsFileName(const JobItem& jobItem) +QString GUI::Model::FilenameUtils::jobResultsFileName(const QString& itemName) { - return intensityDataFileName(jobItem.itemName(), jobdata_file_prefix); + return intensityDataFileName(itemName, jobdata_file_prefix); } //! Constructs the name of the file with reference data. -QString GUI::Model::FilenameUtils::jobReferenceFileName(const JobItem& jobItem) +QString GUI::Model::FilenameUtils::jobReferenceFileName(const QString& itemName) { - return intensityDataFileName(jobItem.itemName(), refdata_file_prefix); + return intensityDataFileName(itemName, refdata_file_prefix); } -QString GUI::Model::FilenameUtils::jobNativeDataFileName(const JobItem& jobItem) +QString GUI::Model::FilenameUtils::jobNativeDataFileName(const QString& id) { - return intensityDataFileName(jobItem.getIdentifier(), nativedata_file_prefix); + return intensityDataFileName(id, nativedata_file_prefix); } //! Constructs the name of the intensity file belonging to real data item. @@ -66,9 +64,9 @@ QString GUI::Model::FilenameUtils::nativeDataFileName(const QString& dataName) return intensityDataFileName(dataName, nativedata_file_prefix); } -QString GUI::Model::FilenameUtils::instrumentDataFileName(const InstrumentItem& instrumentItem) +QString GUI::Model::FilenameUtils::instrumentDataFileName(const QString& id) { - return intensityDataFileName(instrumentItem.id(), instrument_file_prefix); + return intensityDataFileName(id, instrument_file_prefix); } //! Returns list of fileName filters related to nonXML data stored by JobModel and RealDataModel. diff --git a/GUI/Models/Varia/ItemFileNameUtils.h b/GUI/utils/ItemFileNameUtils.h similarity index 63% rename from GUI/Models/Varia/ItemFileNameUtils.h rename to GUI/utils/ItemFileNameUtils.h index 9cab1f5607ac3d128875ed70335ac6e8f4eb89ca..29ca435c89a41e30caea23e401a68bde29d0cdc2 100644 --- a/GUI/Models/Varia/ItemFileNameUtils.h +++ b/GUI/utils/ItemFileNameUtils.h @@ -2,7 +2,7 @@ // // BornAgain: simulate and fit reflection and scattering // -//! @file GUI/Models/Varia/ItemFileNameUtils.h +//! @file GUI/utils/ItemFileNameUtils.h //! @brief Defines namespace GUI::Model::FilenameUtils //! //! @homepage http://www.bornagainproject.org @@ -12,33 +12,29 @@ // // ************************************************************************************************ -#ifndef BORNAGAIN_GUI_MODELS_VARIA_ITEMFILENAMEUTILS_H -#define BORNAGAIN_GUI_MODELS_VARIA_ITEMFILENAMEUTILS_H +#ifndef BORNAGAIN_GUI_UTILS_ITEMFILENAMEUTILS_H +#define BORNAGAIN_GUI_UTILS_ITEMFILENAMEUTILS_H #include <QString> -class InstrumentItem; -class JobItem; -class RealDataItem; - //! Contains set of convenience methods for JobItem and its children. namespace GUI::Model::FilenameUtils { -QString jobResultsFileName(const JobItem& jobItem); +QString jobResultsFileName(const QString& itemName); -QString jobReferenceFileName(const JobItem& jobItem); +QString jobReferenceFileName(const QString& itemName); -QString jobNativeDataFileName(const JobItem& jobItem); +QString jobNativeDataFileName(const QString& id); QString realDataFileName(const QString& dataName); QString nativeDataFileName(const QString& dataName); -QString instrumentDataFileName(const InstrumentItem& instrumentItem); +QString instrumentDataFileName(const QString& id); QStringList nonXMLFileNameFilters(); } // namespace GUI::Model::FilenameUtils -#endif // BORNAGAIN_GUI_MODELS_VARIA_ITEMFILENAMEUTILS_H +#endif // BORNAGAIN_GUI_UTILS_ITEMFILENAMEUTILS_H diff --git a/Tests/Unit/GUI/TestMapperForItem.cpp b/Tests/Unit/GUI/TestMapperForItem.cpp index 0c1680c5575825e9873fb0c0bd632f76b1c0d467..41b596899461fef42980a903dcdc6e1e4f851c75 100644 --- a/Tests/Unit/GUI/TestMapperForItem.cpp +++ b/Tests/Unit/GUI/TestMapperForItem.cpp @@ -1,9 +1,9 @@ +#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/Models/Instrument/MaskItems.h" #include "GUI/Models/Sample/LayerItem.h" #include "GUI/Models/Sample/MultiLayerItem.h" #include "GUI/Models/Sample/SampleModel.h" #include "GUI/Models/Session/SessionItemUtils.h" -#include "GUI/Models/Data/ProjectionItems.h" #include "GUI/Models/Types/DoubleDescriptor.h" #include "Tests/GTestWrapper/google_test.h" #include <memory> diff --git a/Tests/Unit/GUI/TestProjectUtils.cpp b/Tests/Unit/GUI/TestProjectUtils.cpp index 84fd4212e71f6f65e9d91e47d619ef75c27cf234..91706f3ebc21af49221706d1d0284a4226c9f620 100644 --- a/Tests/Unit/GUI/TestProjectUtils.cpp +++ b/Tests/Unit/GUI/TestProjectUtils.cpp @@ -1,6 +1,6 @@ #include "GUI/Models/Project/ProjectUtils.h" -#include "GUI/Models/Varia/ItemFileNameUtils.h" #include "GUI/utils/Error.h" +#include "GUI/utils/ItemFileNameUtils.h" #include "Tests/GTestWrapper/google_test.h" #include "Utils.h" #include <QDir> diff --git a/Tests/Unit/GUI/TestSavingSpecularData.cpp b/Tests/Unit/GUI/TestSavingSpecularData.cpp index d8f398a3b51dbf083591df586e7ca4b6ee1a0e50..69f1c2d86b3ba50591f734a1830daf25b7ca8f7b 100644 --- a/Tests/Unit/GUI/TestSavingSpecularData.cpp +++ b/Tests/Unit/GUI/TestSavingSpecularData.cpp @@ -13,8 +13,8 @@ #include "GUI/Models/Job/JobModelFunctions.h" #include "GUI/Models/Project/OutputDataIOService.h" #include "GUI/Models/Project/ProjectUtils.h" -#include "GUI/Models/Varia/ItemFileNameUtils.h" #include "GUI/utils/Error.h" +#include "GUI/utils/ItemFileNameUtils.h" #include "Tests/GTestWrapper/google_test.h" #include "Tests/Unit/GUI/Utils.h" #include <QTest> @@ -265,9 +265,9 @@ TEST_F(TestSavingSpecularData, test_CopyInstrumentToJobItem) // checking filenames EXPECT_EQ(pointwise_axis_item->fileName(), - GUI::Model::FilenameUtils::instrumentDataFileName(*instrument)); + GUI::Model::FilenameUtils::instrumentDataFileName(instrument->id())); EXPECT_EQ(job_axis_item->fileName(), - GUI::Model::FilenameUtils::instrumentDataFileName(*job_instrument)); + GUI::Model::FilenameUtils::instrumentDataFileName(job_instrument->id())); // Saving OutputDataIOService service(&models);