From 1ba1a9b9f63afccfefcd41cc064649314db6259c Mon Sep 17 00:00:00 2001 From: Matthias Puchner <github@mpuchner.de> Date: Sun, 20 Feb 2022 10:51:40 +0100 Subject: [PATCH] rm useless changed-check from onChanged handler --- GUI/View/Instrument/DistributionEditor.cpp | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/GUI/View/Instrument/DistributionEditor.cpp b/GUI/View/Instrument/DistributionEditor.cpp index e2494e48c64..37a346ea0ab 100644 --- a/GUI/View/Instrument/DistributionEditor.cpp +++ b/GUI/View/Instrument/DistributionEditor.cpp @@ -110,10 +110,8 @@ DoubleSpinBox* DistributionSelector::createSpinBox(const DoubleDescriptor& d) { auto* sb = GUI::Util::createSpinBox(m_formLayout, d); connect(sb, &DoubleSpinBox::baseValueChanged, [=](double v) { - if (d.get() != v) { - d.set(v); - emit distributionChanged(); - } + d.set(v); + emit distributionChanged(); }); return sb; } @@ -122,10 +120,8 @@ QSpinBox* DistributionSelector::createSpinBox(const UIntDescriptor& d) { auto* sb = GUI::Util::createSpinBox(m_formLayout, d); connect(sb, QOverload<int>::of(&QSpinBox::valueChanged), [=](int v) { - if (d.get() != v) { - d.set(v); - emit distributionChanged(); - } + d.set(v); + emit distributionChanged(); }); return sb; } @@ -136,10 +132,8 @@ void DistributionSelector::createMeanSpinBox(const DoubleDescriptor& d) if (m_meanConfig->scientific) { auto* sb = GUI::Util::createScientificSpinBox(m_formLayout, d); connect(sb, &ScientificSpinBox::valueChanged, [=](double v) { - if (d.get() != v) { - d.set(v); - emit distributionChanged(); - } + d.set(v); + emit distributionChanged(); }); } else createSpinBox(d); -- GitLab