From 05712a02be017ea50dec1acc533b5cfb922cbc61 Mon Sep 17 00:00:00 2001
From: "Joachim Wuttke (h)" <j.wuttke@fz-juelich.de>
Date: Thu, 11 Nov 2021 18:57:55 +0100
Subject: [PATCH] ditto
---
.clang-tidy | 31 +-------------------
GUI/View/Realspace/RealSpaceBuilderUtils.cpp | 2 ++
2 files changed, 3 insertions(+), 30 deletions(-)
diff --git a/.clang-tidy b/.clang-tidy
index c5ca174f61d..25e82bb166d 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -11,7 +11,7 @@
# As we are not aware of an official way to insert comments in a long string literal,
# we do a dirty little trick: we write comments as if they were no-check specifiers.
#
-Checks: '
+Checks: '*,
-SectionComment_We_disagree_with_the_following_checks__They_shall_remain_permanently_disabled,
@@ -77,32 +77,3 @@ Checks: '
-SectionComment_Temporarily_disabled_checks__We_need_to_investigate_them_one_by_one,
-
-+*-avoid-c-arrays,
-+*-avoid-goto,
-+*-container-size-empty,
-+*-isolate-declaration,
-+*-member-init,
-+*-namespace-comment,
-+*-narrowing-conversions,
-+performance-move-const-arg,
-+performance-no-automatic-move,
-+performance-noexcept-move-constructor,
-+performance-unnecessary-value-param,
-+performance-unnecessary-copy-initialization,
-+readability-avoid-const-params-in-decls,
-+readability-const-return-type,
-+readability-delete-null-pointer,
-+readability-else-after-return,
-+readability-inconsistent-declaration-parameter-name,
-+readability-non-const-parameter,
-+readability-redundant-control-flow,
-+readability-redundant-declaration,
-+readability-redundant-string-cstr,
-+readability-uppercase-literal-suffix,
-+readability-qualified-auto,
-+clang-analyzer-core.NonNullParamChecker,
-+llvmlibc-implementation-in-namespace,
-+llvmlibc-callee-namespace,
-+llvm-qualified-auto,
-'
diff --git a/GUI/View/Realspace/RealSpaceBuilderUtils.cpp b/GUI/View/Realspace/RealSpaceBuilderUtils.cpp
index 62fe53ca563..83537c56455 100644
--- a/GUI/View/Realspace/RealSpaceBuilderUtils.cpp
+++ b/GUI/View/Realspace/RealSpaceBuilderUtils.cpp
@@ -14,6 +14,7 @@
#include "GUI/View/Realspace/RealSpaceBuilderUtils.h"
#include "Base/Const/Units.h"
+#include "Base/Util/Assert.h"
#include "GUI/Model/Material/MaterialItem.h"
#include "GUI/Model/Material/MaterialModel.h"
#include "GUI/Model/Material/MaterialModelStore.h"
@@ -321,6 +322,7 @@ Particle3DContainer GUI::RealSpace::BuilderUtils::particleComposition3DContainer
Particle3DContainer particleComposition3DContainer;
for (const IParticle* pc_particle : pc_vector) {
+ ASSERT(pc_particle);
Particle3DContainer particle3DContainer;
// no abundances are associated with the individual components of ParticleComposition
if (dynamic_cast<const ParticleCoreShell*>(pc_particle)) {
--
GitLab